161610 - testclnt doesn't accept IPv6 format addresses

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

tstclnt's -h option will allow you to enter a DNS hostname or an IPv4 
format dotted-decimal IP address, but it does not accept an IPv6 format
IP address, e.g. of the form ::ffff:1.2.3.4  or ::ffff:0102:0304

This means that tstclnt cannot be used to test IPv6 IP addresses with 
Subject Alternative Names in SSL server certs.

Patch forthcoming.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: proposed patch

This patch switches from using PR_GetHostByName to using 
PR_StringToNetAddr and PR_GetIPNodeByName.  Then, on platforms that don't
actually support IPv6 addresses, it converts back to IPv4.  This works
on Win2k.  But, I'm not sure that the test #if !defined(_PR_INET6) is 
correct to detect all platforms that don't support IPv6.

Review invited.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Mass retarget all my old NSS bugs that were previous targeted at NSS versions
that have now been released.  

Comment 3

[Wan-Teh Chang]

Moved to target milestone 3.8 because the original
NSS 3.7 release has been renamed 3.8.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Remove target milestone of 3.8, since these bugs didn't get into that release.

Comment 5

[Wan-Teh Chang]

Comment on attachment 94428 [details] [diff] [review]
proposed patch

I gave Nelson some suggested changes for this patch.

The upcoming NSPR 4.5 release will have a new function
PR_GetAddrInfoByName, which replaces the deprecated
function PR_GetIPNodeByName.  We should open a bug to
remind us to switch to PR_GetAddrInfoByName when NSPR
4.5 is released.

Comment 6

[Wan-Teh Chang]

Let's try to get this done in NSS 3.9.  The current
patch is already very close.

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v2 - using more NSPR funcs

This patch uses PR_IsNetAddrType and PR_NetAddrToString.
These changes were suggested by Wan-Teh.

Comment 8

[Wan-Teh Chang]

Comment on attachment 132564 [details] [diff] [review]
patch v2 - using more NSPR funcs

r=wtc.

Two suggested changes for the printHostNameAndAddr function.

1. You can use the PR_NetAddrInetPort macro (defined in "prnetdb.h")
to get the port number from a PRNetAddr.

2. To print 'port' (a PRUint16), it seems that %hu (for unsigned short)
would be a better format specifier than %d (for int).

Comment 9

[Nelson Bolyard (seldom reads bugmail)]

I applied Wan-teh's suggestions and checked it in.

/cvsroot/mozilla/security/nss/cmd/tstclnt/tstclnt.c,v  <--  tstclnt.c
new revision: 1.34; previous revision: 1.33