1619664 - Allow to toggle widget.disable-native-theme-for-content without restarting

Status: RESOLVED FIXED

(Core :: Widget, task)

Description

[Emilio Cobos Álvarez (:emilio)]

It is just so annoying :)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1619664 - Remove nsBox::gTheme. r=dholbert

The boxes can just poke at the prescontext theme like literally everything else.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1619664 - Decide which theme to use per document, not per-process. r=mstange,spohl

This allows testing much more easily.

There are some edge cases with native theme changes and such (ThemeChanged and
co assume there's only one theme per process). But I don't think they matter
much for our use cases.

Depends on D65161

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1619664 - Rename and don't null-check nsPresContext::GetTheme as it can't return null. r=dholbert

There were some callers in nsRangeFrame that were already not-null-checking.

All platforms have a native theme and should we add new ones they could use
nsBasicNativeTheme.

Depends on D65162

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4532abf9270b
Remove nsBox::gTheme. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/c1e88fa43e7e
Decide which theme to use per document, not per-process. r=mstange,spohl
https://hg.mozilla.org/integration/autoland/rev/ebafc021b885
Rename and don't null-check nsPresContext::GetTheme as it can't return null. r=dholbert

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/4532abf9270b
https://hg.mozilla.org/mozilla-central/rev/c1e88fa43e7e
https://hg.mozilla.org/mozilla-central/rev/ebafc021b885