Closed
Bug 162144
Opened 22 years ago
Closed 20 years ago
nsIFilePicker.show can throw exceptions
Categories
(Other Applications Graveyard :: Venkman JS Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: rginda)
References
()
Details
Attachments
(1 file)
|
1.46 KB,
patch
|
rginda
:
review+
|
Details | Diff | Splinter Review |
please change your show() callers to handle the possibilty that show() throws an exception (important) and please don't access the file field in the case that the user clicks cancel (trivial). I'd write a patch but i can't think of how to write it to match the style of your code.
|
||
Comment 1•20 years ago
|
||
|
Assignee | |
Comment 2•20 years ago
|
||
Comment on attachment 145784 [details] [diff] [review] Simple patch to catch exceptions r=rginda
Attachment #145784 -
Flags: review+
|
|
||
Comment 3•20 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Core → Other Applications
|
||
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•