162326 - 550 errors cause throbber to spin endlessly

Status: VERIFIED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[Doug Turner (:dougt)]

if a file doesn't have the right permission, ftp does not send onStart/onStop.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Darin Fisher]

Comment on attachment 94931 [details] [diff] [review]
patch v.1

sr=darin, but bbaetz really needs to review this.

Comment 3

[benc]

so this happens with any situation a 550 is returned?

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 94931 [details] [diff] [review]
patch v.1

Yeah, this looks fine.

r=bbaetz

Comment 5

[Doug Turner (:dougt)]

Checking in nsFtpConnectionThread.cpp;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp,v  <-- 
nsFtpConnectionThread.cpp
new revision: 1.242; previous revision: 1.241
done
Checking in nsFtpConnectionThread.h;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.h,v  <-- 
nsFtpConnectionThread.h
new revision: 1.98; previous revision: 1.97
done

Comment 6

[benc]

Doug: can you give a sample URL and describe what you meant by "spin?"

(Can't verify if I don't know what I'm looking for).

Comment 7

[Doug Turner (:dougt)]

put a file up on your ftp server with no permissions (chmod 000 foo), then try
to download it.

you can look at ftp://z.mcom.com/ (my nscp internal box) for two examples.

Comment 8

[benc]

Using that link, I get a "530 Can't set guest privileges."

(using Mozilla 1.1b, Mac OS X)
I took a quick look at a file on my server that has no read permissions, and the
throbber does run while the error is displayed, then it says "document has no data".

Is this what you were looking at?

Comment 9

[Doug Turner (:dougt)]

just create two files on your unix box.  chmod them to have no permission. then
try to reproduce.

my box doesn't know who you are... no nis/yp installed or ftp guest access.

Comment 10

[benc]

I think I've got the test case you are suggesting, but my observed behavior is
different.

I'm seeing two things that might be wrong:

1- The throbber runs while the error message is up.
2- I get "document contains no data" at the end.

Comment 11

[Doug Turner (:dougt)]

1- The throbber runs while the error message is up.
  expected.
2- I get "document contains no data" at the end.
  really.  that should not be the case.  what is the url that your using so that
i can try it?

Comment 12

[Hansoo Kim]

Doug,

I tried the patch, it does not make any difference in embedding client.

It still behavior the same way with/out the patch.

1) Have FTP server running... ( I an using IIS )
2) Go to the root of ftp site, which has one file with NO ACCESS.
3) Try to retreive the file, and make sure you get 550 error.
4) Now stop the FTP server.
5) Try again on file.

Embedding client ==> Let me save to ZERO byte file.
Mozilla and MFC Embedding ==> Error AFTER Save AS box.


I tried on 8/4/02 trunk ( before the patch checked in ) and
9/8/2002.

Both eventually work the same way, which is
it eventually put error msg about not being able to read from server file AFTER 
save as box, except 8/4/02's Mozilla skips save as box directly to error msg.

Any thoughts ?

P.S.: Will put the jpeg image on error dialog.

Thanks.

Comment 13

[Hansoo Kim]

Attachment: Screen shot on error msg dialog

This is error msg I was talkig about in previous comment.

Thanks

Comment 14

[Boris Zbarsky [:bzbarsky]]

OK.  Just a quick summary of an email conversation I had with Doug:

1)  The ftp channel will pop up an alert when an error occurs saying that the
    error occured.  It will then call OnStopRequest with an error code.
2)  The save-as code will pop up an error alert (like what you see in attachment
    98491 [details]) if its OnStopRequest is called with an error code.  It has to do this
    to handle protocols, like HTTP, for which the channel does no error
    notification of its own.

So you are seeing two alerts for the same error.

Comment 15

[Hansoo Kim]

Ok...

Here we go again.

I am using 1.0.1 for embedding client.
I tested the test case with 1.0 build of mozilla and it has the behavior I was talking 
about. ( So as the 1.0.1 build I am using. )

First since those builds do not have this bug's patch, it hangs.
But besides the hanging, it let me save to to zero content file.

I tested with /pub/mozilla/nightly/2002-09-09-08-1.0
STR is

1) Have FTP server running... ( I an using IIS )
2) Go to the root of ftp site, which has one file with NO ACCESS.
3) Try to retreive the file, and make sure you get 550 error.
  ==> It hangs after, diff from trunk build which has the patch for this bug.
4) Now stop the FTP server.
5) Try again on file.

It lets you save to zero byte file withouot any error.

Can anyone look at that and fix the problem in those branches ?

Thanks.

Comment 16

[Doug Turner (:dougt)]

Attachment: Updated patch

Attached is an update patch which fixes a bug bz found in the first patch
(shift clicking links resulted in two loads).

Hansoo, are you able to apply and test this patch?

This does not fix (or tries to fix) the screen shot you reported.  This is
being addressed in another bug.

Comment 17

[Hansoo Kim]

Doug,

Yes I tried the patch and hanging part is fixed by this patch.

Can you tell me then which bug is addressing the problem I was talking about in 
my last few comments ?

Thanks

Comment 18

[Doug Turner (:dougt)]

I am asking for permission to check the patch into the branch.  I think we need
to create a new bug for the download problem which you have described in this
bug.  I had though that there was a different bug, but I guess not.

Comment 19

[Doug Turner (:dougt)]

spin off bug:
http://bugzilla.mozilla.org/show_bug.cgi?id=167820

Comment 20

[benc]

Is this Win only? I was able to reproduce it only on Win98 on mozilla 1.1.

Comment 21

[Hansoo Kim]

Doug...

Are you landing this on 1.0.1 branch soon ?

Thanks.

Comment 22

[Doug Turner (:dougt)]

I have sent mail to [e-mail] and am waiting a response.

Comment 23

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 94931 [details] [diff] [review]
patch v.1

a=[e-mail] for 1.0 branch.  Change mozilla1.0.2+ to fixed1.0.2 when
checked in.

Comment 24

[Doug Turner (:dougt)]

fixed.
Checking in nsFtpConnectionThread.cpp;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp,v  <-- 
nsFtpConnectionThread.cpp
new revision: 1.237.2.6; previous revision: 1.237.2.5
done
Checking in nsFtpConnectionThread.h;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.h,v  <-- 
nsFtpConnectionThread.h
new revision: 1.96.4.2; previous revision: 1.96.4.1
done

Comment 25

[benc]

VERIFIED: win 98, Mozilla 1.2a does not have problem, Mozilla 1.1 did.
I checked Mac OS X and Linux to make sure they did not have this specfic problem.

Comment 26

[Gayatri Rimola]

Please verify the bug. Once verified, change the keyword fixed1.0.2 to
verified1.0.2 

Comment 27

[benc]

VERIFIED/BRANCH:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.2) Gecko/20020924
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20020924
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.0.2) Gecko/20020924

I think you get bug 151935 fixed for free on Mac OS and Linux too, because they
don't happen anymore in 1.2 or 1.0.2.