162947 - leak in nsXULDocument

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[Alec Flett]

we're leaking a bunch of little 8 byte BroadcastListener objects - the patch is
very simple and cleans up a ton of leaks from purify (26 of these on
startup/shutdown)

patch forthcoming.

Comment 1

[Alec Flett]

Attachment: free up the listeners in ClearBroadcasterMapEntry

simple enough. can I get sr=waterson, r=jst?
(grabbed jst just because he was the next-most-blamed in this file after
hyatt..)

Comment 2

[Alec Flett]

oh what the heck, add hyatt too in case he wants to review this 3-line leak fix :)

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 95477 [details] [diff] [review]
free up the listeners in ClearBroadcasterMapEntry

r/sr=jst

Comment 4

[timeless]

Comment on attachment 95477 [details] [diff] [review]
free up the listeners in ClearBroadcasterMapEntry

r=timeless
[origin for reference is:
2005				 bl = new BroadcastListener;
2012				 entry->mListeners.AppendElement(bl);
]

Comment 5

[Alec Flett]

thanks folks

Comment 6

[rbs]

+    for (PRInt32 i = entry->mListeners.Count(); i>= 0; --i) {

I updated my tree and am seeing assertions. Should have started at count-1.

Comment 7

[Alec Flett]

ugh. duh.
I'll fix it when the tree opens.

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

In the past, I saw this every time I'd run Purify, thanks for fixing this Alec.

No more appear to be leaking under my latest Purify run.

Verified FIXED, trunk Mozilla debug build.