162960 - chrome registry doesn't enumerate overlays installed in user profile.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Glen Nakamura]

This bug involves installing XPIs with overlays into the profile folder.
In contrast to Bug 125610, I find that it *is* possible to install the XPI
into my profile folder and an "overlayinfo" directory is indeed created.
However, when mozilla restarts, the overlay is not loaded...

nsOverlayEnumerator::GetNext() only enumerates overlays from the installed
directory and not the user's profile.

Comment 1

[Glen Nakamura]

Attachment: enumerate overlays from user profile folder

This patch fixes the problem for me...	I'm able to install XPIs with
overlays into my user profile and load them when mozilla restarts.
I assumed that installed overlays should be enumerated before the profile
overlays, but if the reverse is true, then mCurrentArcs should probably
be initialized to mProfileArcs instead of mInstallArcs in the constructor.

Comment 2

[Glen Nakamura]

Hmm... According to Bug 160354, RDF is orphaned.
I'm really not sure where bugs relating to nsChromeRegistry belong.
Skinability? XP Apps? XUL?  Help!

Comment 3

[Glen Nakamura]

Attachment: test case which installs overlay into user profile

I hope this helps the QA people:  The installer should create a new task button

in the task bar (next to the ChatZilla icon in the lower left corner).
Without the patch, the overlay isn't loaded, and the mozilla icon doesn't
appear.
After applying the patch, the mozilla icon appears as expected, and clicking on

it pops up an alert box containing "Test case for Bug 162960".

Comment 4

[Glen Nakamura]

Forgot to mention that you should restart the browser after installing
the XPI...  I'd like to get this into 1.0.1 if possible, so if someone could
verify the bug and the patch, I would very much appreciate it!!!

Comment 5

[Daniel Veditz [:dveditz]]

Thanks for the patch! I'll play with it.

Comment 6

[Thomas Thurman]

Did the patch get applied?

I've tested the example xpi (attachment 97262 [details]) with both 1.3b (2003021008) and
1.0.2 (2002121607). In both cases:

 * The xpi creates the overlays correctly in the profile directory.
 * On restart, the icon doesn't show in the component bar.
 * However, strace shows that Moz did read the overlay.
 * The chrome has been registered correctly. (I can go to
chrome://bug162960/content/bugzilla-16.png and see the icon.)

I'd guess from this that the patch didn't make it. What's happening?

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 95489 [details] [diff] [review]
enumerate overlays from user profile folder

dave, dan, can you guys see if this is any good. If so, it would be great to
get this in early in 1.4 and let the extensions developers get started making
mods and alterations.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Note that the only way to get hyatt to review is to mail him in person -- he
does not read bugmail and does not look at his review queue... 

Comment 9

[Peter Van der Beken [:peterv]]

Attachment: First check profile, then install

Comment 10

[Peter Van der Beken [:peterv]]

Taking bug.

Comment 11

[David Hyatt]

Comment on attachment 116228 [details] [diff] [review]
First check profile, then install

sr=hyatt

Comment 12

[Jan Varga [:janv]]

Comment on attachment 116228 [details] [diff] [review]
First check profile, then install

looks good and works great
r=varga

Comment 13

[[e-mail]]

Yet more *%$# overlay directories? :-/

Comment 14

[Jan Varga [:janv]]

Neil, I think it was already supposed to work in both directories, this is just
a bug not new feature

Comment 15

[Peter Van der Beken [:peterv]]

Checked in.

Comment 16

[Chris Neale]

Attachment: testcase with Phoenix support

Comment 17

[Daniel Veditz [:dveditz]]

It's either have the overlay directories in your profile, or have to re-install
add-ons each time you upgrade Mozilla.

Comment 18

[HJ]

What happens when someone installed an add-on in his mozilla/chrome directory
and later updates the smae add-on in his profile/chrome?

Comment 19

[Chris Neale]

extension writers could do with a template install.js to enable this

i.e.

give user option to install locally/globally, also checking that their build is
capable of local installation

Comment 20

[Matthias Versen [:Matti]]

Comment on attachment 95489 [details] [diff] [review]
enumerate overlays from user profile folder

removing obsolete review requests