Closed
Bug 163024
Opened 23 years ago
Closed 23 years ago
bugzilla_email_append.pl calls processmail incorrectly
Categories
(Bugzilla :: Bugzilla-General, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: bbaetz, Assigned: bbaetz)
Details
(Whiteboard: [fixed in 2.16.1] [fixed in 2.14.4] [fixed on trunk])
Attachments
(1 file)
696 bytes,
patch
|
bugreport
:
review+
preed
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•23 years ago
|
||
Bleh. Stupid enter key...
Anyway, as jussi pointed out in bug 160631, bugzilla_email_append.pl uses the
same quoting that bug_email.pl used, which was fixed for bug 154008:
system("cd .. ; ./processmail $found_id '$SenderShort'");
is not the way to go. We should fix that....
Severity: normal → critical
Priority: -- → P1
Whiteboard: [want for 2.16.1]
Target Milestone: --- → Bugzilla 2.18
Assignee | ||
Comment 2•23 years ago
|
||
This patch WFM. (modulo the usual bug_email bugs)
Comment 3•23 years ago
|
||
What happened to "cd .."?
Gerv
Assignee | ||
Comment 4•23 years ago
|
||
Its not needed since bug 154008 went in - ie this is another breakage from that.
Comment 5•23 years ago
|
||
Comment on attachment 95666 [details] [diff] [review]
patch
r=joel assuming that someone has confirmed that the routined still does its
desired function.
Still need a seperate 2xr for 2.16 branch.
Attachment #95666 -
Flags: review+
Comment 6•23 years ago
|
||
Comment on attachment 95666 [details] [diff] [review]
patch
People still use this stuff?!
Wild.
r2=preed
Attachment #95666 -
Flags: review+
Assignee | ||
Comment 7•23 years ago
|
||
Yes, people still use this (unfortunately)
Checked in to trunk and 2.16/2.14 branches
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: [want for 2.16.1] → [fixed in 2.16.1] [fixed in 2.14.4] [fixed on trunk]
Comment 8•23 years ago
|
||
Removing security bit for publication in status report.
Group: webtools-security?
Assignee | ||
Comment 9•23 years ago
|
||
Err... Weren't we waiting for 2.16.1 before removing the sceuirity bit? Readding
the security bit for now....
Group: webtools-security?
Comment 10•23 years ago
|
||
Security Announcement is posted. removing the security bit.
Group: webtools-security?
Updated•13 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•