163137 - DOM Inspector only scroll to the right element if it is HTML

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[rbs]

Follow-up to bug 112817.

The fix that was done only works for HTML documents (because the function used,
element.scrollIntoView, is only defined for the HTML DOM). So the whole world of
XML/XHTML/MathML was left out of the equation.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Actually, XHTML is fine, since it creates HTMLElement instances.... but yes, the
other stuff is not fine.

I'll see whether I can do this without messing with the selection too much...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase -- click on the "foo" elements inside the <li>s

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

Comment 4

[Boris Zbarsky [:bzbarsky]]

This patch would be fine except for one little thing.... scrollSelectionIntoView
is broken at times.  I have not figured out when exactly... if I use
ANCHOR_REGION, then scrolling to the last <li> in the testcase does not work. 
If I use FOCUS_REGION I get weird things on tinderbox at times....

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Using scrollFrameIntoView

Put a cool scroll method on our flasher interface, and make it use
nsIPresShell::ScrollFrameIntoView()

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 106333 [details] [diff] [review]
Using scrollFrameIntoView

r/sr=bzbarsky.... I need to start thinking outside the box...

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 106333 [details] [diff] [review]
Using scrollFrameIntoView

r/sr=bzbarsky.... I need to start thinking outside the box...

Comment 8

[Boris Zbarsky [:bzbarsky]]

Wow.  Bugzilla's not dealing well with submission during a backup... ;)  anyway,
this is all your, Chris.

Comment 9

[rbs]

Comment on attachment 106333 [details] [diff] [review]
Using scrollFrameIntoView

r=rbs

For the curious, it works nice with MathML. Since MathML has a lot of tiny
frames, you can really appreciate the flasher there -- as you navigate in those
tiny frames. Turn View->ShowWhitespaceNodes off and point your inspector at
<math> nodes in:
http://www.mozilla.org/projects/mathml/start.xml

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in.