163235 - Left Arrow caret movement wrong after selection unselected

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect)

Description

[Brent]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1b) Gecko/20020722
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1b) Gecko/20020722

Happens in a text area such as the one used to type this.  If some text is
selected starting from the end of a line, then unselected with Left Arrow, then
the next Left Arrow moves the caret to the end of the previous line.  Used the
text from bug 96704.  Problem is very similar to that bug.


Reproducible: Always

Steps to Reproduce:
1. In a text area type:
one
two
three
2. Move cursor to end of "two"
3. Hit <Shift-RightArrow> 2 times.  The 't' in "three" will be selected.
4. Hit LeftArrow.  't' is unselected, caret is at end of "two"
5. Hit LeftArrow again.  Caret moves to end of "one".
Actual Results:  
Caret moves to the end of the previous line.  If that line is outside the view
area, the window does not scroll as it would if UpArrow was hit.

Expected Results:  
Caret should move to be between "wo".

Comment 1

[Brent]

On step 2, to get to the end of word "two", use the arrow keys.
Caret movement is correct if <End> is used to get to the end of "two".

2. Position the caret somewhere on "two".  Hit <End><RightArrow><LeftArrow>.  If
instead hit <End><LeftArrow><RightArrow> then the caret moves correctly in step 5.

Comment 2

[Brent]

Simplified test

In an empty textarea type:

a<Enter>b<Enter>c<LeftArrow><LeftArrow>
<Shift-RightArrow><Shift-RightArrow><LeftArrow><LeftArrow>

Comment 3

[Kevin McCluskey (gone)]

I can reproduce this 11/1/2002 trunk build on WinNT.
EDITORBASE+

Comment 4

[mjudge]

yeah i see this.

Comment 5

[mjudge]

Attachment: patch for content/base/src/nsSelection.cpp

This fixes the problem here.  The "HINT" gets flopped around while selecting
forwards in the document.  We then forget to swap it back after jumping to the
beginning of the selection.  If you snap (backwards) in the document like in
this example, you need to set the hint to the right.  if you snap (forwards)
say by selecting text and hitting down or right arrow, then you need to set the
hint to "left" to stick to the proper frame.

Comment 6

[mjudge]

checked in

Comment 7

[sairuh (rarely reading bugmail)]

looks fine. vrfy'd fixed with 2003.04.23 comm builds.