Closed
Bug 164385
Opened 23 years ago
Closed 23 years ago
SetDirty() often uses uninitialized rv
Categories
(Core Graveyard :: History: Global, defect)
Core Graveyard
History: Global
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ajschult784, Assigned: bugzilla)
References
()
Details
Attachments
(1 file)
|
682 bytes,
patch
|
dbradley
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
found this with valgrind
if mSynctimer is non-null (after the first time SetDirty is called), then
do_CreateInstance is not called, but rv is still checked and SetDirty returns
failure if NS_FAILED(rv) is true.
this code came from bug 65862.
|
Reporter | |
Comment 1•23 years ago
|
||
|
|
Reporter | |
Updated•23 years ago
|
|
||
Comment 2•23 years ago
|
||
Comment on attachment 96535 [details] [diff] [review]
only check rv if do_CreateInstance is called
r=dbradley
Attachment #96535 -
Flags: review+
|
|
||
Comment 3•23 years ago
|
||
Comment on attachment 96535 [details] [diff] [review]
only check rv if do_CreateInstance is called
thanks!
sr=alecf
Attachment #96535 -
Flags: superreview+
|
|
Reporter | |
Comment 4•23 years ago
|
||
*** Bug 165030 has been marked as a duplicate of this bug. ***
|
|
Reporter | |
Comment 5•23 years ago
|
||
blaker, dbradley or alecf: could one of you check this patch in to CVS? thanks
Keywords: review
|
|
||
Comment 6•23 years ago
|
||
Patch checked in
|
||
Comment 7•23 years ago
|
||
SetDirty() often uses uninitialized rv
Patch was checked in 40 days ago: 2002-11-13
Why is that bug status still marked NEW, not resolved?
It is one of twenty bugs blocking bug 179819
|
|
||
Comment 8•23 years ago
|
||
Because I forgot?
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•