164838 - Changing date pref doesn't update task list

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[ajbu]

Changing the date pref. doesn't update the task list. patch follows

Comment 1

[ajbu]

Attachment: patch for rootCalendarPref.js

Adds toDoUnifinderRefesh(); Note that both unifinders use 'Refesh' not
'Refresh'
This patch also changes the loadPreferences function. Note that prefs are no
longer stored if they are the default values, so only changed prefs are stored.
I am Not sure there are strong arguments to store all prefs, even with default
values?

Comment 2

[Mike Potter]

Checked into cvs, also function spelling mistake is fixed.

Comment 3

[ajbu]

Oops, didn't do all the tests properly.
There is a problem with calendarManager, line 230:
         if( this.CalendarWindow.calendarPreferences.calendarPref.getBoolPref
( "servers.reloadonlaunch" ) == true 
This should not read directly from the pref.file, but use the calendarWindow 
prefarray function.
I'm not sure if line 215 is what is wanted:
var NumberOfCalendars = 
this.CalendarWindow.calendarPreferences.arrayOfPrefs.numberofservers;

Other units like dateUtils.js use the getPref function for that:

this.CalendarWindow.calendarPreferences.getPref( "dateformat" )

Comment 4

[ajbu]

i'll add a new bug for the problem mentioned

Comment 5

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!