165332 - chatzilla should give better error messages when /join fails

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Samuel Sieb]

There are specific error codes for when a join fails for different reasons.
For example: 475 ERR_BADCHANNELKEY  "<channel> :Cannot join channel (+k)"
Instead of just displaying the message, chatzilla should give a clearer reason
for the error, like "You need a key", or "You entered the wrong key".

Comment 1

[James Ross]

Attachment: Display better messages for join errors

I thought it would be nice to make replacing random error numerics easy, so
this code just tries to find a string, and if it fails it falls back to the old
code. Patch includes the four join errors that I could find.

Comment 2

[James Ross]

Comment on attachment 141194 [details] [diff] [review]
Display better messages for join errors

Checked in.

Comment 3

[Michael Lefevre]

there's a couple of mistakes in one of the messages that got added here

"This channel has reached it's set capacity; you connot join it."

"it's" should be "its" and "connot" should be "cannot"

Comment 4

[James Ross]

Attachment: Fixes errors in text