165558 - building with --disable-logging and GTK2 default widget fails to compile

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[DJ]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1) Gecko/20020826
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1) Gecko/20020826

Using v1.1 release tarball.  Using these configure options:

--prefix=/usr/mozilla
--with-pthreads
--with-system-jpeg
--with-system-zlib
--with-system-png
--enable-default-toolkit=gtk2
--disable-toolkit-gtk
--disable-toolkit-qt
--disable-gtktest
--enable-freetype2
--enable-xft
--enable-optimize=-O2
--enable-xinerama
--disable-tests
--disable-debug
--disable-logging
--enable-strip
--enable-default-mozilla-five-home=/usr/mozilla
--disable-libIDLtest
--disable-glibtest

The build fails in widget/src/gtk2/nsWindow.cpp.  It didn't seem to error out
anything useful.  It gave a bunch of warnings and some C++ code forbidden
notices but nothing to indicate anything that would error out like that.  Am I
missing anything?  If I leave out the --disable-logging, it compiles as normal.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Actual Results:  
Compile fails at widget/src/nsWindow.cpp

Expected Results:  
It should've compile.


I'm flagging this as minor since the simple workaround to this is removing the
--disable-logging option.  But I would like to have used it otherwise.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

what is the error?

Comment 2

[hacker formerly known as [e-mail]]

Over to the gtk2 guys.  The LOG() macros should be wrapped in PR_LOGGING ifdefs.

Comment 3

[Christopher Blizzard (:blizzard)]

Hmm, I was using PR_FORCE_LOGGING - or at least I thought I was.

Comment 4

[Marco Pesenti Gritti]

Attachment: include prlog.h also with --disable-logging

The header need to be included anyway. #define FORCE_PR_LOG will enable/disable
it.
This is how it's done in other files in mozilla tree. 
I did this patch some time ago and I thought to have submitted a bug. Will mark
as dup if I find it ;)

Comment 5

[hacker formerly known as [e-mail]]

Comment on attachment 97229 [details] [diff] [review]
include prlog.h also with --disable-logging

If you make that change, you'll need to remove gWidgetLog from the PR_LOGGING
ifdef at
http://lxr.mozilla.org/seamonkey/source/widget/src/gtk2/nsAppShell.cpp#55 as
well.

Comment 6

[Marco Pesenti Gritti]

You are right. And I missed your previous comment about wrapping LOG() in
PR_LOGGING. I should read all comments before submitting stuff.
I guess I'll let blizzard decide how he wants to fix this :)

Comment 7

[Norman Jonas]

Attachment: A ( better ) build patch for --disable-logging

I think that this patch is better. It works and it really disables logging, if
--disable-logging is used. ( The other patch doesn't seem to disable logging
... )

Comment 8

[DJ]

Build still fails at same place unless patched, with CVS (checked out 11/18/2002
3:50PM EST) and MOZILLA_1_2_BRANCH source.  Any updates on this?  It hasn't been
filed as a dup yet.

Comment 9

[Bolian Yin]

-> change owner

Comment 10

[Tommi Komulainen]

Attachment: Updated attempted fix

I copied the structure from dom/src/base/nsJSEnvironment.cpp so it should be
correct.

Comment 11

[Drew "DanteAliegri" Ogle]

Attachment: fix for gtk2 build error with --disable-debug

Comment 12

[Drew "DanteAliegri" Ogle]

the attached patch was suggestd by timeless in #mozilla.
he seend to feel that a include file race was being triggered,
and moving the include order fixed this.
Build works after patch is applied.

Comment 13

[Christopher Blizzard (:blizzard)]

Attachment: patch

Or, even better, just remove the MOZ_LOGGING since we're using FORCE_PR_LOG.

Comment 14

[Christopher Blizzard (:blizzard)]

Fixed.

Comment 15

[hacker formerly known as [e-mail]]

That's the wrong fix.  The MOZ_LOGGING ifdef is needed so that we can disable
the logging using --disable-logging.  The FORCE_PR_LOG define should always be
wrapped inside a MOZ_LOGGING ifdef.

Comment 16

[Jon Foster]

I recently built LFS CVS 20030219 and now I'm working on BLFS CVS 20030404. I
have run into the same problem using gtk+ 2.2.1 source and mozilla 1.2.1 source
with logging disabled.

Error message:

nsWindow.cpp: In destructor `virtual nsWindow::~nsWindow()':
nsWindow.cpp:301: `gWidgetLog' undeclared (first use this function)
nsWindow.cpp:301: (Each undeclared identifier is reported only once for each 
   function it appears in.)
nsWindow.cpp:301: warning: left-hand operand of comma expression has no effect
nsWindow.cpp:301: `PR_LOG' undeclared (first use this function)
nsWindow.cpp: In member function `virtual nsresult nsWindow::Destroy()':

...

nsWindow.cpp: In function `void IM_preedit_changed_cb(GtkIMContext*, 
   nsWindow*)':
nsWindow.cpp:3469: warning: left-hand operand of comma expression has no effect
nsWindow.cpp:3469: warning: left-hand operand of comma expression has no effect
make[4]: *** [nsWindow.o] Error 1
make[4]: Leaving directory `/usr/src/lfs/mozilla/build/widget/src/gtk2'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/usr/src/lfs/mozilla/build/widget/src'
make[2]: *** [libs] Error 2
make[2]: Leaving directory `/usr/src/lfs/mozilla/build/widget'
make[1]: *** [libs] Error 2
make[1]: Leaving directory `/usr/src/lfs/mozilla/build'
make: *** [all] Error 2

I will try again with logging enabled.

Comment 17

[Jon Foster]

Attachment: Jon Foster's config-moz.log

Comment 18

[Jon Foster]

Removing --disable-logging from the config options solved my problem.

Comment 19

[Christopher Blizzard (:blizzard)]

Working on this is going to be waaaay down on my todo list.  If you give me a
patch, though...

Comment 20

[cls]

Attachment: Disable widget logging when given --disable-logging

Comment 21

[chris hofmann]

Comment on attachment 185416 [details] [diff] [review]
Disable widget logging when given --disable-logging

a=chofmann

Comment 22

[cls]

Checking in widget/src/gtk2/nsCommonWidget.h;
/cvsroot/mozilla/widget/src/gtk2/nsCommonWidget.h,v  <--  nsCommonWidget.h
new revision: 1.24; previous revision: 1.23