166723 - selected labels should only be inverted when they are focussed

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[timeless]

i've 'switched' to mozmail.. which explains why i'm filing more bugs in it.

20002090408 newclassic/classic w32 (confirmed w/ unix users and stuff).

select a message, press 0 (no label)
1. focus the message preview pane
1' selection changes from blue to grey
2. focus the thread pane
3. press 1
3' thread pane line background is red
4. focus the message preview pane
4' thread pane line background is *still* red
5. select another message
5' the red message is now red text on default background

the problem is that in step 4' you can't figure out if the threadpane or the
message preview pane if focussed.

this causes me a lot of problems possibly because of other focus bugs which seem
to be randomly focussing the preview pane.

The fix is to make 4' have red text and grey background. (mixing 1' and 5')

Comment 1

[timeless]

Attachment: make the rule more specific

Comment 2

[jglick]

There should be a black border around the entire inside of the pane that 
currently has focus. Are you not seeing this?

Comment 3

[Mike Cowperthwaite]

(In reply to comment #2)
> There should be a black border around the entire inside of the pane that 
> currently has focus. Are you not seeing this?

In fact, for Thunderbird 0.9, the answer to this question is No.

However, Timeless' original observation is correct regardless of whether the 
focus ring is visible -- the selected unlabelled messages appear differently 
depending on whether the pane (the tree) has focus or not, and the labelled 
messages should be handled identically.

However, I cannot figure out how the patch might be applied to the current 
scheme of things; I can't locate anything about labels in the CSS files.

Comment 4

[[e-mail]]

Mike, this is actually quite a simple patch as it goes; because of the way cvs
diff works it mentions the file name no fewer than four times and the patch is
just a search-and-replace. r=me once it's unbitrotted and copied to Modern ;-)

Comment 5

[Mike Cowperthwaite]

Attachment: diff -u, classic theme, Moz 1.8a5-1122 (non-CVS)

Updated the patch to fix the double-colon issue for proprietary pseudoclasses.

The threadPaneLabels.css file is identical to the last byte in the Classic and
Modern themes, so I don't know if there's anything to be gained by posting a
patch for Modern as well, since I'm not using CVS diff anyway.


The file is also identical in the Qute theme, but I can't get TB to show the
expected results with the changed version of qute.jar -- any tips on how to
address that?

Comment 6

[[e-mail]]

Comment on attachment 167264 [details] [diff] [review]
diff -u, classic theme, Moz 1.8a5-1122 (non-CVS)

Ah yes, those pesky double colons, I overlooked them :-[

I have no idea about the Qute theme.

Comment 7

[Mike Cowperthwaite]

Comment on attachment 167264 [details] [diff] [review]
diff -u, classic theme, Moz 1.8a5-1122 (non-CVS)

Scott, besides reviewing this, do you have any ideas w.r.t. my inability to get
a patched qute.jar working in TB?

Comment 8

[Mike Cowperthwaite]

More oddness -- I've got this patch tucked into the qute.jar for my TB 1.0 
installation, and I just noticed -- it works in newsgroups, but not in mail 
(or RSS).  Why would that be?

Comment 9

[Mike Cowperthwaite]

(In reply to comment #8)
> More oddness -- I've got this patch tucked into the qute.jar for my TB 1.0 
> installation, and I just noticed -- it works in newsgroups, but not in mail 
> (or RSS).  Why would that be?

I see now that the trunk builds of TB don't even have threadPaneLabels.css in 
the trunk; the desired coloration is still performed in news, but not in mail 
(nor in RSS).

So I tracked down the rules, again; these have been moved to mailWindow1.css; I 
noticed an additional set of identical rules in searchDialog.css.  And in fact, 
changing the rules in mailWindow1.css works to give the desired results, for 
mail and RSS -- except in the Search dialog; but updating the rules in the 
Search dialog, the desired coloration appears there as well.

Double checked against Mozilla -- the current patch applies to Search as well as 
the main window.  Scott, why is it that those rules need to appear separately in 
Search?

Anyway, patch coming up.

Comment 10

[Mike Cowperthwaite]

Attachment: diff -u, qute theme, TB 1.0+0316 (non-CVS)

The format of this diff is a little odd, sorry; I couldn't figure out how to
get a consolidated diff from two local files without the text complaining about
the files which weren't changed not being present in the 'old' directory.

Comment 11

[[e-mail]]

Comment on attachment 178052 [details] [diff] [review]
diff -u, qute theme, TB 1.0+0316 (non-CVS)

TB only needs scott's review

Comment 12

[Mike Cowperthwaite]

Thanks for the sr's!  

Neil has applied the first patch to the modern and classic themes for Seamonkey. 
(Thanks, Neil!)  Would someone please do the same with the second patch for the 
qute and pinstripe themes for TB?

Comment 13

[Scott MacGregor]

I couldn't get this non CVS patch to apply in my tree and I'm too lazy to apply
each one of these changes by hand.

Comment 14

[timeless]

Attachment: diff -u, qute theme -trunk cvs-

Comment 15

[Scott MacGregor]

thanks. Fix checked in. 

Comment 16

[Mike Cowperthwaite]

V with TB 1.0+0715 (Alpha 2), Win2K.  Thanks, Timeless.