166912 - Account settings change appears not to take effect (HTML compose, Bcc, Server Username)

Status: NEW

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[laurel]

Using sep05 commercial trunk build
Regression since branch

On a multiple accounts profile, unchecking the "compose messages in HTML format"
then visiting another account's settings and going back to the first will make
it look like the first setting change didn't take.

Steps:
1.  Open a multiple account profile, go to Account Settings (all accounts have
the compose in HTML format option enabled).
2.  For the first account, uncheck/disable the HTML compose setting. Keep
account settings dialog open.
3.  Select the next account in the settings dialog, then go back to the first
account in the settings dialog.  Notice the checkmark is present on the first
account's HTML compose setting, although you previously unchecked it.
4.  OK/confirm account settings dialog and return to the first account.  Note
the uncheck/disable of the HTML compose option did indeed take, it just didn't
appear to before you confirmed the dialog.

Result:  Looks like the first change to account settings didn't take if you
visit another account in settings dialog and return.  First account's panel
didn't refresh properly.

Comment 1

[laurel]

Not sure if this affects other account settings, just observed with the HTML
compose option.

Comment 2

[Peter 'vt100' Schwindt]

*** Bug 166272 has been marked as a duplicate of this bug. ***

Comment 3

[Jörg Heinicke]

The same for bug #168821, can somebody mark it as duplicate?

Comment 4

[JoSH Lehan]

I have noticed that this happens whenever a change is made in any Account
Settings pane (such as "Server Settings" for an email account), then another
pane is clicked on without first hitting "OK".

When the second pane is displayed, changes to the first pane are discarded. 
Even if the user returns to the first pane, changes will still be lost.  This is
frustrating when changing multiple panes of settings at a time.

Strangely, this only happens for some settings, not all of them.  The behaviour
seems not to be consistent.

I recommend putting an "Apply" button in the dialog.  The user could hit "Apply"
to save changes for that pane, without needing to leave the dialog.

Perhaps unsaved panes (before the user presses "OK" or "Apply") could be
highlighted in red, similar to how the Linux KDE GUI works with its control panel.

Comment 5

[Brian Rogers]

*** Bug 191620 has been marked as a duplicate of this bug. ***

Comment 6

[Brian Rogers]

*** Bug 168821 has been marked as a duplicate of this bug. ***

Comment 7

[Ninoschka Baca]

*** Bug 199361 has been marked as a duplicate of this bug. ***

Comment 8

[Ninoschka Baca]

The same problem occurs in the Copies & Folders panel for the Bcc settings.

Comment 9

[Ninoschka Baca]

Changing Summary from "Account settings (HTML compose) change appears not to
take effect" to "Account settings change appears not to take effect (HTML
compose, Bcc, Server Username)

Comment 10

[(not reading, please use [e-mail] instead)]

taking

Comment 11

[Samir Gehani]

Mail triage team: nsbeta1+/adt2

Comment 12

[(not reading, please use [e-mail] instead)]

re-assigning to shuehan

Comment 13

[shliang]

Attachment: patch

fix checkboxes in acct manager so that they remember state correctly when pane
is switched

Comment 14

[(not reading, please use [e-mail] instead)]

wait, don't other UI elements have a similar problem?  like the text area where
we list the addresses to bcc?

Comment 15

[shliang]

Attachment: patch

Comment 16

[shliang]

Comment on attachment 119756 [details] [diff] [review]
patch

that last patch wasn't right, i think i found the real problem (see checkin for
bug #60639)

Comment 17

[(not reading, please use [e-mail] instead)]

Comment on attachment 119756 [details] [diff] [review]
patch

r/sr=sspitzer

yikes.	nice catch.

Comment 18

[(not reading, please use [e-mail] instead)]

ok, I've landed the fix on the branch, and I'll leave it to shuehan to land the
fix on the trunl.

Comment 19

[Cavin Song]

Comment on attachment 119756 [details] [diff] [review]
patch

r=cavin.

Comment 20

[shliang]

resolving

Comment 21

[Ninoschka Baca]

Trunk build 2003-04-22: WinXP -  fixed.

Trunk build 2003-04-22: Mac 10.1.5, Linux RH 8 - still a problem.
- In Account Settings, for a Mail account select a Copies & Folders panel, and
edit the Bcc setting.
- Select a Copies & Folder panel for a News account
- Switch back to the Mail account's Copies & Folder panel and the change is not
present.

Reopening.

Comment 22

[shliang]

hmm. i am not seeing this on my mac (don't have linux though)

Comment 23

[shliang]

tried linux, also wfm

ninoschka, could you give me an exact case? i tried checking/unchecking the
compose html and bcc checkboxes, and typing/deleting in the bcc textbox.

Comment 24

[Ninoschka Baca]

Please try the following - the following case requires switching b/n Mail & News:

- Open a profile with a Mail and News account
- For the Mail account, go to Account Settings, Copies & Folders and change the
Bcc setting
- Now switch to the News account's Copies & Folders panel
- Then switch back to the Mail account's Copies & Folders panel

Comment 25

[Ninoschka Baca]

Additional Information:

The problem appears only for migrated profiles on the Mac. I can't reproduce the
issue with new profiles. The following are the scenarios I tried:

Mac 10.1.5
1. Buffy0424: New profile - ok
2. N7.02: New profile then launched the same profile in today's build - ok.

3. Buffy0424: Migrated profile - displays the problem
4. 7.02: Migrated profile then launched the same profile in today's build -
displays the problem.

Windows new and migrated profiles are also ok.

Comment 26

[Ninoschka Baca]

In a migrated profile on the Mac the problem appears to only be the Copies &
Folders, Bcc section:

1. Copies & Folders, Bcc 
- Edit the Bcc setting in a mail account so it has a checkmark and some text
- Switch to a News Copies & Folders panel which has no Bcc entry
- Switch back to the mail account Copies & Folder panel and now the Bcc setting
is blank.

I checked the following areas which were ok:
- Account Settings: Your Name, Email Address, HTML checkbox
- Server Settings: Server Name, User Name

Comment 27

[(not reading, please use [e-mail] instead)]

clearing "fixed in 1.3" from status whiteboard, since this was reopened.

Comment 28

[Samir Gehani]

adt: nsbeta1-

Comment 29

[Tony Mechelynck [:tonymec]]

- Mozilla1.4 is long past, retargeting to Future.
- Is someone still seeing this bug on SeaMonkey 2.0a1pre ? See comment #24 and what follows it, and note that Suiterunner profiles are not in the same location as Suite / Sm 1.x profiles. The setting of browser.preferences.instantApply (true or false) might also perhaps influence the result.
- I'm not sure whether MailNews Account Settings are currently handled by XPFE or New Toolkit, hence adding a few CCs.

Comment 30

[Tony Mechelynck [:tonymec]]

Resetting A+QA to defaults (both were @formerly-netscape.com.tld).