167305 - Folded references: headers are parsed incorrectly

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Ere Maijala (slow)]

Folded (split to multiple lines) references: headers in messages are parsed
incorrectly, leading to wrong threading. Patch coming up.

Comment 1

[Ere Maijala (slow)]

Attachment: Patch to fix parsing of references (bypass cr and lf), also few indentation cleanups

David, could you review this?

Comment 2

[David :Bienvenu]

Comment on attachment 98285 [details] [diff] [review]
Patch to fix parsing of references (bypass cr and lf), also few indentation cleanups

great, sr=bienvenu, thx.

Comment 3

[Scott Collins]

Comment on attachment 98285 [details] [diff] [review]
Patch to fix parsing of references (bypass cr and lf), also few indentation cleanups

Looks reasonable.  Depending on how likely I thought it would be that |*ptr ==
0|, I might have moved that half of the |&&| to the front.  For future
reference, please use pre-increment when that it what you mean (yes, I see that
you didn't touch that part of the code).

Comment 4

[Ere Maijala (slow)]

Thanks. Looks like the first half is false much more often than the second, so I
think the current order is good.

Comment 5

[(not reading, please use [e-mail] instead)]

why this change?

@@ -395,7 +395,6 @@
   }
   else {
     ParseReferences(references);
-    m_numReferences = m_references.Count();
   }
 	
   SetUInt32Column(m_numReferences, m_mdb->m_numReferencesColumnToken);

Comment 6

[David :Bienvenu]

it's just whitespace, I believe. Ere, can you do -uw diff?

Comment 7

[David :Bienvenu]

yes, that line is not needed because ::parseReferences does the same thing.

Comment 8

[Ere Maijala (slow)]

Yes, I was just about to say that. Forgot to tell about it before.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 98285 [details] [diff] [review]
Patch to fix parsing of references (bypass cr and lf), also few indentation cleanups

a=asa (on behalf of drivers) for checkin to 1.2a

Comment 10

[Ere Maijala (slow)]

Fix checked in.