Closed
Bug 16742
Opened 25 years ago
Closed 24 years ago
Crash with scaled-down PNG with 8-bit alpha mask
Categories
(Core :: Graphics: ImageLib, defect, P2)
Tracking
()
VERIFIED
FIXED
M16
People
(Reporter: sfraser_bugs, Assigned: pnunn)
References
()
Details
(Keywords: crash)
Attachments
(1 file)
919 bytes,
patch
|
Details | Diff | Splinter Review |
When displaying a page containing a PNG which has been scaled, the application heap gets trashed (like we wrote off the end of a buffer somewhere). This does not happen when the same image is not scaled. This problem occurs on http://jazz/users/pnunn/publish/pngpix/aaaa3.html, even when the file is pared down to contain just <html> <body bgcolor=#ffff00 > <img src="allgrad1.png" width=10> </body> </html>
Updated•25 years ago
|
Severity: normal → critical
Priority: P3 → P2
s: Is this with using the 8 bit mask mac code or the old 1 bit mask code? -pn
Reporter | ||
Comment 2•25 years ago
|
||
This was with the 8-bit mask code (reverting back a revision on that file, and changing the #if 0).
This is critical only if the last pngcom changes are backed out and set up to generate 8 bit masks. I'm pushing to m15. Beep me if needed, Simon. -pn
Adding "crash" keyword to all known open crasher bugs.
Keywords: crash
Fixing this bug is dependent on mac and linux work done on the same problem. Checkin must be coordinated. I am pushing this to m16. It will be my first focus on m16. -P
Target Milestone: M15 → M16
checked in changes to code that scales down. Marking fixed so it gets tested. -P
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
oops. reopening. I fixed binary dithered mask scaling, not 8bit mask scaling. duh. -pn
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Checked in.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Comment 10•24 years ago
|
||
Verified fixed in this morning's builds on Win/Mac/Linux. Specifically, the page listed in URL field does not trigger a crash when displayed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•