167561 - make nsPrefWindow.js work with non-tree controls & key substitutions

Status: VERIFIED INVALID

(SeaMonkey :: Preferences, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

I'm using the nsPrefWindow.js code for a new dialog window which can be used
with multiple servers (similar to the filters window, that respect).  I've done
a bit of hacking on nsPrefWindow.js so that it allows any arbitrary control (not
just the prefsTree) to be used to choose the page.  I'm also incorporating
eddyk's %keyword% substitution changes from bug 79305, as this is necessary to
effectively use this infrastructure with identical pages but differing data. 
I'll attach a patch shortly.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: work-in-progress patch, v1

The data-persistence doesn't quite work yet and there are some other loose ends
to clean up.  But basic control via any kinda of widget should work.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: work-in-progress patch, v2

* Add keyword substitution param to initPanel()

* Allow the tag param to be null, with the semantic of "get the tag from page
frame".  Fix up queued initialization to handle this

Still some loose ends to tie up.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch, v3

OK, I'm not entirely satisfied with this code, but it now does keyword
substitution properly.	I'd be interested in any reviewer feedback about
overall structure...

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch, v4

Fixes a bug where the substition object wasn't always being remembered
correctly.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch, v5

Comment 6

[(not reading, please use [e-mail] instead)]

is this patch still needed?  the spam UI I wrote doesn't require it.

Comment 7

[(not reading, please use [e-mail] instead)]

marking invalid.  this patch isn't needed.

Comment 8

[sairuh (rarely reading bugmail)]

v