168236 - add buddy icons to message header area

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

Now that we have aim icons showing in addressbook (see
http://bugzilla.mozilla.org/attachment.cgi?id=98835&action=view,
http://bugzilla.mozilla.org/show_bug.cgi?id=168108), we can just do the exact
same trick for the message pane!

No encoding / decoding X-Face headers.  (which, according to the standard/RFC,
must be 48 x 48 black and and white images. for more about x-face, see
http://bugzilla.mozilla.org/show_bug.cgi?id=20417)

So instead, let's just follow what I did for AB.

Look in the PAB for the screenname of the sender.  If we have it, and I've got
aim.session.screenname pref is set, look for a file at:

gProfileDirURL.spec + "/NIM/" + myScreenName + "/picture/" + senderScreenName +
".gif

If that exists, show it in the message pane area.

The great thing about this, and about the AB showing icons, is:

1) we get icons for free, if you use 7.x NIM.  (we get pref UI for choosing, we
get efficient downloading from other people, etc)

2) as is, mozilla can use the feature too.  They just have to set prefs and dump
icons in the right spot.

Comments?  Suggestions on where to put the icon in the message pane header area?
 What about when viewing "collapsed" headers?  (I say hide it.)
What about if there is attachments or signed/unsigned.

Comment 1

[(not reading, please use [e-mail] instead)]

accepting

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: patch

fix.  here comes a screen shot.

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of buddy icon in mail and ab

Comment 4

[(not reading, please use [e-mail] instead)]

fixed.

Comment 5

[(not reading, please use [e-mail] instead)]

see http://www.mozilla.org/mailnews/arch/buddyicons.html for details.

Comment 6

[[e-mail]]

Comment on attachment 99247 [details] [diff] [review]
patch

In this patch you made at least five errors:

>+       if (gIconFileURL.file.exists()) {
The image is quite capable of detecting whether or not the file exists.

>+   fromBuddyIcon.setAttribute("src", "");
You should use removeAttribute(src) here.

>+  <vbox autostretch="never">
>+    <spacer flex="1"/>
>+    <image style="padding: 5px" id="fromBuddyIcon"/>
>+    <spacer flex="1"/>
>+  </vbox>
>+
autostretch="never" was removed from xul ages ago;
don't align using <spacer>;
don't put inline style on elements.

What you want is
msgHdrViewOverlay.xul:
<hbox align="center">
  <image id="fromBuddyIcon"/>
</hbox>

messageHeader.css:
#fromBuddyIcon {
  padding: 5px;
}
Note: Combined with removeAttribute("src") you could use
#fromBuddyIcon[src] {
  padding: 5px;
}
which would remove the padding when you removed the src URL.

Comment 7

[esther]

Verified winxp, macosx and linux trunk builds 20021029.

Comment 8

[(not reading, please use [e-mail] instead)]

I've moved the issues neil raised to bug #193364, for future cleanup.