168269 - collection improvements: grab incoming display names and screennames to improve PAB

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[(not reading, please use [e-mail] instead)]

collection improvement, grab incoming display names to improve PAB

we can look at incoming mail
see if email is in PAB

if so, and we don't have a display name
put that in the card in the PAB.

Comment 1

[(not reading, please use [e-mail] instead)]

see bug 167571 and http://www.mozilla.org/mailnews/arch/cab.html

mscott, if you think this make sense, can you ammend 
http://www.mozilla.org/mailnews/arch/cab.html?

accepting for 1.2beta

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: patch.

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: autocollect screennames if domain is @aol.com or @netscape.net

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 7

[(not reading, please use [e-mail] instead)]

mscott, to add to your document:

1)  on collection, don't set the display name to be the username (from 
username@domain). 

2)  if collecting outgoing, when getting incoming, if we get a display name in 
the header and we have a card for that email address, set the display name (if 
one is not already set.)

3)  on collection, if domain is [e-mail] or [e-mail], set 
the aimscreenname to be username (if one is not already set).

marking fixed.  we still have some collision issues and some interCAPS issues 
to deal with, but those are going to be spin off bugs.

Comment 8

[(not reading, please use [e-mail] instead)]

in addition to aol.com and netscape.net, we can do the screenname trick for 
cs.com.  will check that in today.

Comment 9

[(not reading, please use [e-mail] instead)]

I've added all the info about what we implemented to scott's pab doc on mozilla.

Comment 10

[Joe.C]

Your addition to nsMsgSend.cpp for this bugs seems to be wrong. Please see the
line in DeliverFileAsMail function:

  if (mCompFields->GetBcc() && *mCompFields->GetBcc(), PR_TRUE) {

This will cause the last part always be TRUE and will add a "," to the address
lists. It will cause some double byte name not translate correctly. Please see
my comment in bug 163933 for detail.

Comment 11

[Ninoschka Baca]

Trunk build 2002-11-21: WinMe, Linux 8 , Mac 10.1.3
Verified Fixed. I love how this works!