168452 - PSM embedding freeze/ final step/ mark interfaces as frozen

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P1)

Description

[Kai Engert (:KaiE:)]

Juan, if my list is correct, the following is the full list of interfaces we
want to freeze. Please comment in the bug if the list is not complete.

nsICRLInfo
nsIX509Cert
nsIX509CertDB
nsIX509CertValidity
nsIASN1Sequence
nsIASN1Object
nsICertificateDialogs
nsIBadCertListener
nsISecurityWarningDialogs

Comment 1

[John Unruh]

Cna this be marked fixed, now that all the depends on bugs are fixed?

Comment 2

[Kai Engert (:KaiE:)]

What we have to do is produce a simple patch that adds the appropriate comments
that will mark the interfaces as frozen.

We should do this for 1.3 final.

Comment 3

[Kai Engert (:KaiE:)]

Luckily we have not yet frozen the interfaces.

I would like to make a reasonable change to nsIX509Cert.

The change will not create additional work for embeddors, since nsIX509Cert is
used by embeddors, but not implemented by them.

Since a cert can store multiple email addresses, we are adding a way to obtain
the list of all email addresses contained in the cert.

Bug 50823 implements the change.

Comment 4

[Juan José Mata]

Nominating topembed.

Comment 5

[saari (gone)]

removing topembed nomination as this is a meta bug. Please nominate the
individual bugs (although they all look to be fixed)

Comment 6

[Kai Engert (:KaiE:)]

Adding back nomination. It's not a meta bug, we need to produce a patch that
marks the interfaces as frozen, as required by the embedding docs.

Comment 7

[Michael Buckland]

Discussed in bug triage.  Does the milestone relflect reality and when do we
expect this to happen?

Comment 8

[Kai Engert (:KaiE:)]

I will produce the patch today.

Comment 9

[Kai Engert (:KaiE:)]

Attachment: Patch v1

Comment 10

[Kai Engert (:KaiE:)]

Comment on attachment 122567 [details] [diff] [review]
Patch v1


This is to finalize the freeze process we started a while ago. No modifications
to the interfaces happened since we talked about it (with the exception of the
small addition in bug 50823, as previously announced).

Can you please review?

Comment 11

[Javier Delgadillo]

Comment on attachment 122567 [details] [diff] [review]
Patch v1

r=javi

Comment 12

[Alec Flett]

Comment on attachment 122567 [details] [diff] [review]
Patch v1

sr=alecf

Comment 13

[Kai Engert (:KaiE:)]

Comment on attachment 122567 [details] [diff] [review]
Patch v1

Requesting approval for freezing interfaces.

This patch only adds the @status FROZEN comments.

Comment 14

[(not reading, please use [e-mail] instead)]

Comment on attachment 122567 [details] [diff] [review]
Patch v1

a=sspitzer

Comment 15

[Asa Dotzler [:asa]]

Has this landed yet? I don't see anything in bonsai. 

Comment 16

[Kai Engert (:KaiE:)]

It has not yet landed! Thanks for the reminder. Will land today.

Comment 17

[Kai Engert (:KaiE:)]

fixed on trunk

Comment 18

[John Unruh]

Verified per Kai's comment.