Closed Bug 168479 Opened 22 years ago Closed 21 years ago

if smb has sign '<' in nickname (in From field) U cannot cite his letter well

Categories

(MailNews Core :: Composition, defect)

Product:
MailNews Core
Component:
Composition
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: karpieszuk, Assigned: bugzilla)

References

Details

Attachments

(3 files)

Proposed patch
2.56 KB, patch
Details | Diff | Splinter Review
Updated for joe's comments
2.93 KB, patch
Brade
: review+
mscott
: superreview+
asa
: approval1.5-
Details | Diff | Splinter Review
Supplementary patch
1.16 KB, patch
bugzilla
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.1) Gecko/20020826 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.1) Gecko/20020826 My From filed is: From: |<onrad <hereis@my.address> When somebody using Mozilla Mail&News try to answer on my letter he has problem with citing my nickname. Correct cite is: Mr |<onrad wrote in massege: > here is cited messege but Mozilla show only: Mr | > here is messege I think i know what causes the problem: Mozilla recognize sign '<' as beginning of the email address. But maybe U can change it? It is better to recognize '<something@something>' as correct email and ignore sign '<' without '@' and '>' after this. I belive it will be repared in future (maybe in 1.2 official) :) Reproducible: Always Steps to Reproduce: 1. no special setups; 2. 3.
rfc822 states the following: http://www.faqs.org/rfcs/rfc822.html --- specials = "(" / ")" / "<" / ">" / "@" ; Must be in quoted- / "," / ";" / ":" / "\" / <"> ; string, to use / "." / "[" / "]" ; within a word. --- So your From field should be constructed as: "|<onrad" <someone@somewhere)
but it doesn`t work :( i changed my From field on: From: "|<onrad" <address@ad> and i`ve sent email to me. i receive it (in from field was |<onrad without quotes). i tried to reply, and one more time it was just: Mr | > cited If U want I can write massege to U, then U will see
Still there in 1.3 Final and 1.4b.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Somebody I know from usenet has nick |<onrad, and I can't automatically quote him.
Yes Michal, and he is reporter of this bug.
*** Bug 199895 has been marked as a duplicate of this bug. ***
Attached patch Proposed patch — — Splinter Review
This just makes everything use plain text for the <author> wrote: string.
You test it in Message-ID: <3f68b700$0$12148$7b0f0fd3@reader.news.newnet.co.uk> and it looks that it works
Comment on attachment 131622 [details] [diff] [review] Proposed patch strictly from a "does this abuse the editor" viewpoint, this patch looks ok to me. Someone else should confirm that the logic is correct. And while we are here, can we get rid of thise monstrosity: rv += ConvertBufToPlainText(mMsgBody, formatflowed); rv += ConvertBufToPlainText(mSignature, formatflowed); return rv; oh man that's sad.
Attachment #131667 - Flags: superreview?(bienvenu)
Attachment #131667 - Flags: review?(scott)
Comment on attachment 131667 [details] [diff] [review] Updated for joe's comments patch works fine for me.
Attachment #131667 - Flags: approval1.5?
Comment on attachment 131667 [details] [diff] [review] Updated for joe's comments Not reviewed. Not landed and tested on the trunk.Not for 1.5.
Attachment #131667 - Flags: approval1.5? → approval1.5-
Neil: can You check it in?
Not without r/sr; ask scott/david nicely...
Comment on attachment 131667 [details] [diff] [review] Updated for joe's comments Trying different reviewer.
Attachment #131667 - Flags: superreview?(bienvenu) → superreview?(dmose)
Comment on attachment 131667 [details] [diff] [review] Updated for joe's comments Neil, does this still work ok for HTML compose? We took out the <html> open tag and never seem to re-issue it. I though that looked odd. Will something break by no longer having a <html> at the start of the document?
Comment on attachment 131667 [details] [diff] [review] Updated for joe's comments r=brade; please get sr= from mscott or some other mailnews owner
Attachment #131667 - Flags: superreview?(mscott)
Attachment #131667 - Flags: superreview?(dmose)
Attachment #131667 - Flags: review?(mscott)
Attachment #131667 - Flags: review+
It's not the open <html> tag, the code only inserts <html> into the existing document, which never has any effect (you can test this using Insert/HTML).
Comment on attachment 131667 [details] [diff] [review] Updated for joe's comments thanks for answering my question Neil.
Attachment #131667 - Flags: superreview?(mscott) → superreview+
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment on attachment 135307 [details] [diff] [review] Supplementary patch OK, so it turns out that there is a bug in InsertHTML, it ignores the <br> at the end of the html if it's inserting at the end of the document. So what used to happen with the old code is this: (in text compose) "Neil wrote:<br>" is converted to "Neil wrote:\n" and inserted as text. Then, original message is cited using > prefix and inserted as text. (in HTML compose) "Neil wrote:<br>" is inserted as HTML, but <br> is ignored. Then, original message is cited, using <blockquote type="cite"> So, the HTML compose would end up with Neil wrote:<blockquote type="cite"> Now with the new code (or alternatively had the InsertHTML bug been fixed) I insert "Neil wrote:\n" as text without conversion (so that |<onrad will insert properly). Unfortunately this generates an extra <br> in HTML compose that we don't want: Neil wrote:<br><blockquote type="cite"> So, I have removed the \n from the cite prefix generation, only adding it just before inserting into the plain text compose. I patched two insertion sites although I can only get one to be called.
Attachment #135307 - Flags: superreview?(bienvenu)
Attachment #135307 - Flags: review?(ducarroz)
Comment on attachment 135307 [details] [diff] [review] Supplementary patch R=ducarroz
Attachment #135307 - Flags: review?(ducarroz) → review+
Attachment #135307 - Flags: superreview?(bienvenu) → superreview+
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: