168596 - class selectors on non-subject sequence of simple selectors always match XML content

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Sicking noticed that class selectors on (using CSS3 terminology) in any
non-subject sequence of simple selectors always match XML content.  This is bad,
and seems to be due to the NS_COMFALSE nightmare of nsIStyledContent::HasClass
and the inconsistency with GetClasses.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: sicking's testcase

There should not be any red in this testcase.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: the simple fix without any cleanup

This is the simple fix.  We might want to clean things up a bit, though, to
avoid the hated NS_COMFALSE.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yeah.  I say it's time for NS_IMETHOD_(PRBool) here.  sr=me on the patch if
that's needed immediately, though.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 99163 [details] [diff] [review]
the simple fix without any cleanup

r=sicking

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in, 2002-09-16 07:17 PDT.

Filed bug 169088 on fixing the API to avoid NS_COMFALSE (yes, I'm lame).

Comment 6

[Madhur Bhatia]

verified