168743 - Keep Only Unread Messages Does Not Work Consistently

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Dan Star]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1) Gecko/20020826
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1) Gecko/20020826

I have 'News Account Settings > Offline & Disk Space' set to 'Keep Only Unread
Messages' for several news servers.  This feature usually does work or it works
part way.  Restarting Mox makes no difference.

Reproducible: Always

Steps to Reproduce:
1. Add a news server account
2. Change Disk Space settings so only unread messages are kept
3. Add a newsgroup and read some of the messages or mark all read
4. Change to your mail inbox and then go back to the newsgroup.
5. All or some of the read will still be there.

Comment 1

[Dan Star]

Add as well that messages that are marked read but later intentionally marked 
unread will disappear!  This happens on both Windows ME and XP.  And I am not 
misunderstanding the remove read function as I have used it for years in 
Netscape 4.X where it works like a champ.  Anyone else care?

Comment 2

[David :Bienvenu]

could you try a newer trunk build - I think I checked in a fix for the first
problem described 08/10 but I don't know if it was in 1.1 or not

Comment 3

[Dan Star]

I am using 1.1 and I opened this bug on 09/14.  Where is the 08/10 date coming 
from?

Comment 4

[David :Bienvenu]

Dan, I was trying to address my comments to the first problem described, NOT the
one you describe. It can be difficult to deal with bugs where people tack on
different problems that they think are the same, so I'm trying to deal with the
issues one at a time.

Again, I would recommend that both of you try something newer than 1.1 and then
see where we are. I know it's confusing, but I'm not sure if the change I made
on 08/10 made it into the 1.1 build, since the 1.1 build is made on a CVS branch
that may or may not have branched before 08/10, so even though the build date is
08/26, that doesn't mean it has my checkin.

Comment 5

[David :Bienvenu]

Attachment: proposed fix

it turns out that if you have keep all messages set (i.e., don't keep XXX
messages, or messages younger than XX days), but keep unread only set as well,
we weren't purging read messages. This patch fixes that.

Comment 6

[David :Bienvenu]

fix checked in.