168755 - [CasCadeS] inefficient code in SerializeExternalSheet

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Darin Fisher]

this code should not be creating a standard-url.

924 function SerializeExternalSheet(sheet, href)
925 {
926   var nsuri =
Components.classes["@mozilla.org/network/standard-url;1"].createInstance(Components.interfaces.nsIURI);
927   if (href)
928     nsuri.spec = href;
929   else
930     nsuri.spec = sheet.href;
931   var fileURL = nsuri.QueryInterface(Components.interfaces.nsIFileURL);
932   var localFile = fileURL.file;
933   var fileOuputStream =
Components.classes['@mozilla.org/network/file-output-stream;1'].createInstance(Components.interfaces.nsIFileOutputStream);
934   try {
935     fileOuputStream.init(localFile, -1, -1, 0);

instead, you should replace it with something like the following:

var ios
  = Components.classes["@mozilla.org/network/io-service;1"]
              .getService(Components.interfaces.nsIIOService);
var fileHandler
  = ios.getProtocolHandler("file")
       .QueryInterface(Components.interfaces.nsIFileProtocolHandler);
var localfile
  = fileHandler.getFileFromURLSpec(href);

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Thanks for contributing and thanks for the hint, Darin :-)
Btw, the component for CaScadeS is Editor:Composer.
Changing. Accepting bug.

Comment 2

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

I was not fast enough : we now have a new component Editor:CSS Editor

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

code added to CaScadeS and ready to check-in, thanks Darin.

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

fix checked in trunk 11/07/2002 01:24