169140 - Composer horked due to errors in ComposerCommands.js

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

seen on stdout, using a fresh build 2002-sept-17 03:14am californian time :

An error occurred updating the cmd_bold command:
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)
[nsICommandParams.getBooleanValue]"  nsres
ult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://editor/content/ComposerCommands.js :: goUpdateComm
andState :: line 369"  data: no]

I see this error message occur for cmd_bold cmd_italic cmd_underline  cmd_tt ...
[skip a dozen or more] cmd_ol cmd_ul

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Wow, even switching to alltags or preview mode is horked !!!
raising radar indicators

Comment 2

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

confirming on linux RH72

Comment 3

[[e-mail]]

I don't see this, is that because I added "return;" at line 346?
(I did that to fix a ton of warnings I saw when opening Editor).

Comment 4

[Kathleen :Brade]

-->brade I'll look at this

Comment 5

[Kathleen :Brade]

Attachment: patch to fix mode switching

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 99518 [details] [diff] [review]
patch to fix mode switching

r=glazman
the command errors disappear after a clobber build

Comment 7

[jag (Peter Annema)]

Comment on attachment 99518 [details] [diff] [review]
patch to fix mode switching

sr=jag

Comment 8

[Charles Manske]

This patch is part of the patch to bug 124265, but was not checked in.
Since that was reviewed, I'll check in this ASAP.

*** This bug has been marked as a duplicate of 124265 ***

*** This bug has been marked as a duplicate of 124265 ***

Comment 9

[Charles Manske]

Since this has all needed reviews, we might as well reopen and just check it 
in! Brade will do that when tree opens.

Comment 10

[Kathleen :Brade]

fix checked in

Comment 11

[Charles Manske]

*** Bug 169261 has been marked as a duplicate of this bug. ***

Comment 12

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

people, I pulled a fresh tree this morning and, building from scratch and I
am ***still seeing*** the errors in ComposerCommands I originally reported.
Can someone else confirm please ?

Comment 13

[rubydoo123]

reopening based on last comment made by Daniel. Please mark resolved fixed as
appropriate.

Comment 14

[Kathleen :Brade]

I don't see this problem; resolving as fixed