16916 - Space bar should scroll the message and then move to next unread message.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[lchiang]

Space bar should scroll the message and then move to next unread message

10/20/99 build Win32

1) Open Inbox
2) You have several unread messages
3) Select one of them which is causes the scroll bar to appear in the message
pane and place focus in the message pane
4) Press space bar
5) The message scrolls until the end of the message is reached
6) Press space bar again

Actual result:  nothing happens
Expected results:  The next unread message gets selected in the thread pane and
displayed in the message pane

Add'l notes:  This is a feature in 4.x which I greatly rely on to read through
my messages and news postings in an efficient manner.  If possible, would like
this in 5.0 :-)

Comment 1

[Phil Peterson]

Reassign to alecf

Comment 2

[Alec Flett]

adding putterman to this.
There are huge focus architectural issues to fix before we even have a shot at
this in a reliable manner.

Comment 3

[Phil Peterson]

I was wondering if/when we were going to get to this feature. FWIW, I really
miss it. Is it really M16?

Comment 4

[selmer (gone)]

Are the huge architectural issues with focus resolved now?

Comment 5

[selmer (gone)]

[FEATURE] bugs past M16 are OUT for this release.  Marking M20.  If you disagree 
with this action, please help me explain it to the PDT.

Comment 6

[lchiang]

:-(

Comment 7

[Alec Flett]

I think this is polish that we need for the product - users have been using this 
feature since 3.x
Taking off feature radar, because it's not a FEATURE, it's more of a featurelet

Comment 8

[Phil Peterson]

I don't want to play schedule chicken, but I really miss this feature too. Will
defer to Alec and Steve's judgement about when/if this could be done.

Comment 9

[scottputterman]

Mass moving to future

Comment 10

[Matthew T (active 1999-2002)]

Don't forget the dialog when you're jumping between folders/groups: `Continue to 
next unread message in {folderName/groupName}?' (The dialog has keyboard focus on 
the `OK' button, so you can just press Space again to continue.)

Comment 11

[Alec Flett]

cross-folder navigation is a completely different bug... which might not be 
filed..

Comment 12

[lchiang]

I'm sure Laurel has filed it.

It's http://bugzilla.mozilla.org/show_bug.cgi?id=17801 to track cross folder 
navigation.

Comment 13

[Alec Flett]

changing title back to it's original one.. we want to make sure to scroll the 
message when the user hits space.

I've got this partially working in my tree.

Comment 14

[(not reading, please use [e-mail] instead)]

alec, do you still have a partial fix for this?

feel free to attach the patch and hand the bug off to me.

(see #17801, next across folders is working.)

Comment 15

[(not reading, please use [e-mail] instead)]

adding me to the cc list.

Comment 16

[Alec Flett]

Yes, I think so. I'll attach a patch.

Comment 17

[Alec Flett]

filters/search UI->gayatrib

Comment 18

[Alec Flett]

oops back to me

Comment 19

[(not reading, please use [e-mail] instead)]

taking from alecf.

add jst, who has some sort of patch.

Comment 20

[Johnny Stenback (:jst)]

Well, what I have is not really anything I'm proud of and it doesn't really work
all the time either, I hacked on this months back and found this in one of my
trees today. This patch does make mozilla scroll when pressing space when
reading a news message and if we're at the bottom of the message it skips to the
next unread message. The problem is that sometimes the code makes mozilla go to
the next unread message w/o scrolling so that needs to be fixed before this is
ready for prime time. I'm guessing the event handler runs in the wrong
window/context sometimes so we're not able to scroll the content window. I'll
attach the patch.

Comment 21

[Johnny Stenback (:jst)]

Attachment: "hack" that hooks up space to scroll and move to next unread message, at least sometimes :-)

Comment 22

[laurel]

as mentioned in bug triage meeting yesterday, am nominating spacebar navigation
releated bugs.

Comment 23

[scottputterman]

marking nsbeta1-, though if someone can get the patch to work correctly, it
would be taken.

Comment 24

[James Green]

Keywords/nomination: 4xp, mozilla0.9, mozilla1.0.

Comment 25

[scottputterman]

moving to future.

Comment 26

[Johnny Stenback (:jst)]

Attachment: Proposed fix.

Comment 27

[Johnny Stenback (:jst)]

Please reconsider this one, annoying bugs like this one is what makes people
think this product sucks. The lates attachment works, if someone who understands
the mailnews UI code could spend 5 minutes looking at the patch and testing what
it does I think it could be ready for checkin.

Please, please, please. Pretty please!

Comment 28

[Ben Goodger (use ben at mozilla dot org for email)]

I can provide a=[e-mail]. Someone from mailnews should review...

Comment 29

[KANEUCHI Tetsuya]

Johnny, it's great!! It works fine on my own build on Linux.

But I prefer moving to 'next message' (not 'unread') with space bar.
So I modified your patch and it makes me happy now.

Comment 30

[Johnny Stenback (:jst)]

Cool :-)

I think mozilla should follow what NS4.x did tho, and go to the next unread
message when you press space. You're always free to do whatever you want in your
own build, of course :-)

Comment 31

[scottputterman]

FYI, the nsbeta1- and the future refer to the current owner of the bug doing the
fix.  If someone else contributes a good patch then we'll take it.

So, thanks for the patch.  It'll make a lot of keyboard users happy.

Comment 32

[Asa Dotzler [:asa]]

Seth, looks like this one is ready to go pending mail review and and sr=.

Comment 33

[(not reading, please use [e-mail] instead)]

now that the performance branch has landed I'll work on getting this landed.

Comment 34

[(not reading, please use [e-mail] instead)]

fixed.  thanks for the patch jst.

Comment 35

[fenella]

Linux (2001-03-26-05 mtrunk)
Win32 (2001-03-26-09 mtrunk)
Mac (2001-03-26-12 mtrunk)
Verify this one. However, crash occurs when scrolling using space bar on News.
See bug 73485,