16951 - nsTextFormater needs to be renamed to nsTextFormatter

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[Mike Shaver (:shaver emeritus)]

and it really should happen before we get to dogfood.  People are going to
(hopefully) write a lot of code that calls this i18n-friendly formatter, and
it's quite confusing to have a misspelled API class name.

(And we're still paying for HTTP_REFERER, 5 years later.)

Comment 1

[Suresh Duddi (gone)]

Scott can you handle this.

Comment 2

[Scott Collins]

No problem.  Based on the comments, marking this [DOGFOOD].

Comment 3

[Suresh Duddi (gone)]

Scott, I dont this this is DOGFOOD. We can ship dogfood without fixing this. I
would just leave this M11 or M12.

Comment 4

[Scott Collins]

OK.  Un-marking it as dogfood, then :-)

Comment 5

[Scott Collins]

I have changes for this in my local tree which I will check in when I arrive in
California this coming week.

Comment 6

[Scott Collins]

Not dogfood.

Comment 7

[Sammy Ford]

scc do you still have these changes, or I can do this instead, it that is
better.

Comment 8

[Scott Collins]

If you're on this, go ahead... there aren't very many instances.  Email me the
diffs and I'll review.  The only annoying part is renaming the files.

Comment 9

[Sammy Ford]

Assigning to myself until this is done.

Comment 10

[Sammy Ford]

closing

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Reopening.  nsTextFormater has not been cvs remove-d from the tree.  There are
also a few lingering references.  It would be best to remove it to avoid
confusion (so people don't make changes to or get confused by an obsolete file).

LXR shows:
http://lxr.mozilla.org/seamonkey/search?string=nsTextFormater

So it just needs to be removed from the MANIFEST, the comments in nsDirPrefs.cpp
should be changed, and it should be cvs-removed.  I'm willing to do this if
nobody else wants to...

Comment 12

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

OK... taking this.  I'll do it.

Comment 13

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch for review (plus a cvs remove of xpcom/ds/nsTextFormater.{h,cpp})

Comment 14

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Note to self:  nsTextFormatter.cpp may need to be removed from a Mac project file.

Comment 15

[Erik van der Poel]

r=erik

Comment 16

[Brendan Eich [:brendan]]

sr=[e-mail]

Comment 17

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in, 2000-11-07 19:02.