169789 - PPEmbed and Chimera fail to save view-source:

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: Mac, defect)

Description

[Conrad Carlen (not reading bugmail)]

The work the header sniffer does fails on such a URL. We end up with some
fallback  file name without a suffix. Since no suffix, we do:
mimeService->GetFromMIMEType(mContentType.get(), ...)
and since the content type is "text/html; x-view-type=view-source", that fails
and we bail.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch

This fixes it. Need r=/sr=.

Comment 2

[Conrad Carlen (not reading bugmail)]

Fixing summary.

Comment 3

[Conrad Carlen (not reading bugmail)]

Still looking for r=/sr=.

Comment 4

[Simon Fraser [no longer active]]

Comment on attachment 99891 [details] [diff] [review]
patch

sr=sfraser

Comment 5

[Mike Pinkerton (not reading bugmail)]

+            if (Substring(uriSpec, 0, 12).Equals("view-source:")) {
+                const nsACString& srcSpec = Substring(uriSpec, 12,
uriSpec.Length() - 12);

rather than |12| here, i'd like to see you use strlen("view-source:") or a
constant at least -- i'm guessing that's where the 12 comes from ;)

otherwise r=pink

Comment 6

[Simon Fraser [no longer active]]

*** Bug 164361 has been marked as a duplicate of this bug. ***

Comment 7

[Ludovic Hirlimann [:Usul]]

Mike why was this one not checked in ?

Comment 8

[Mike Pinkerton (not reading bugmail)]

*** Bug 217708 has been marked as a duplicate of this bug. ***

Comment 9

[Mike Pinkerton (not reading bugmail)]

conrad, this file is in the attic, what do we need to change for camino to get
it to do the right thing?

Comment 10

[Conrad Carlen (not reading bugmail)]

Attachment: patch v2

Here's a new patch against current camino

Comment 11

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 138423 [details] [diff] [review]
patch v2

r=pink

Comment 12

[Conrad Carlen (not reading bugmail)]

Comment on attachment 138423 [details] [diff] [review]
patch v2

clearing request for sr= since Camino

Comment 13

[Conrad Carlen (not reading bugmail)]

Checked in.