169825 - [FIX]DOM inspector does not show many attributes (GetAttributes broken in XUL)

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[Aaron Leventhal]

When using DOM inspector to look at navigator.xul, look at the <textbox> element
for the address bar. (You can search for id="urlbar").

For some reason, only about 3 attributes are showing up, when there are a lot more:

        <textbox id="urlbar" class="chromeclass-location" flex="1"
                 type="autocomplete" searchSessions="history" 
                 timeout="50" maxrows="6" alwaysopenpopup="true"
                 disablehistory="false" accesskey="d"
                 defaultSearchEngine="true" tabScrolling="true"
                 showCommentColumn="true"
                 inputtooltiptext="&locationBar.tooltip;"
                 oninput="window.XULBrowserWindow.userTyped.value=true;"
                 ontextcommand="return handleURLBarCommand(eventParam, domEvent);"
                 ontextrevert="return handleURLBarRevert();"
                 onfocus="URLBarFocusHandler(event);"
                 onmousedown="URLBarMouseDownHandler(event);"
                 onclick="URLBarClickHandler(event);">

It seems to be a big bug for Inspector.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I haven't looked into this or anything, but I bet money that 
nsXULElement::GetAttributes is what's buggy.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Mass re-assigning bugs to [e-mail]

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Short story:  Attributes() is non-null if we have some attrs set to local
values that differ from the prototype.	But it only contains the attrs that are
set locally.  so if we want to use it as the return value of GetAttributes(),
we need to call MakeHeavyweight unconditionally.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Same as diff -w, FOR REVIEW ONLY

Comment 5

[Boris Zbarsky [:bzbarsky]]

Taking.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

hmm.. please add a comment in the code why you do this btw, or just refer to
this bug

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed, with comment added.

Comment 8

[timeless]

Verify Fixed: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7a)
Gecko/20040125
Steps: Comment 0