169830 - Array.concat(function) doesn't add function to the array

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Phil Schwartau]

This is the Rhino version of bug 169795 against SpiderMonkey.
Other datatypes are being successfully pushed by Array.prototype.concat(),
but not function datatypes:

js> x = 'Hi';
Hi
js> [].concat(x);
Hi

js> x = 1;
1
js> [].concat(x);
1

js> x = {};
[object Object]
js> [].concat(x);
[object Object]


js> x = function() {}

function () {
}

js> [].concat(x);
                  <<<------------------- x WAS NOT PUSHED ONTO THE ARRAY !!!
js> [].concat(x).length;
0


By contrast, if we wrap the function object in an array,
Array.prototype.concat() will successfully push it:


js> x = function() {}

function () {
}

js> [].concat([x])

function () {
}

Comment 1

[Phil Schwartau]

The testcase for this bug is

      mozilla/js/tests/ecma_3/Array/15.4.4.4-001.js

Currently failing in both SpiderMonkey and Rhino -

Comment 2

[Igor Bukanov]

Attachment: Use ScriptRuntime.instanceOf instead of hasLengthProperty

Comment 3

[Igor Bukanov]

Committed as the patch passed the testsuite.

Comment 4

[Phil Schwartau]

Igor: do you want to mark this as fixed?

I can verify the fix: the above testcase is now passing 
for me in the rhino and rhinoi shells on WinNT -

Comment 5

[Igor Bukanov]

To Phil: I can not mark the bug as fixed since I do not have permissions to do
so. I changed my account e-mail to [e-mail] as we got better anti-spam
software at work but now I realized that I lost a permission to alter bugs status...

Comment 6

[Phil Schwartau]

Igor: thanks; let me mark this as FIXED, then -

Comment 7

[Phil Schwartau]

Marking Verified FIXED -

Comment 8

[Igor Bukanov]

Targeting as resolved against 1.5R4