170201 - leaks of nsDocument::mPrincipal

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There are some leaks I see starting and exiting mozilla (some
nsAggregatePrincipal and nsCodebasePrincipal and nsSimpleURI objects) that are
caused by bad refcounting of nsDocument's mPrincipal member.  There are a bunch
of places where it is assigned into without releasing the old value.  Rather
than figure out which one was triggering the leak, I just converted it to
nsCOMPtr -- the new code in the patch I'm about to attach should (I think) be
equivalent, except that there are a bunch of places where the old value is now
released before filling in a new one.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch converting nsDocument::mPrincipal into an nsCOMPtr

Comment 2

[Mitchell Stoltz (not reading bugmail)]

Comment on attachment 100166 [details] [diff] [review]
patch converting nsDocument::mPrincipal into an nsCOMPtr

Looks fine to me. r=mstoltz.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 100166 [details] [diff] [review]
patch converting nsDocument::mPrincipal into an nsCOMPtr

sr=jst

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2002-09-23 18:27 PDT.