Closed
Bug 170438
Opened 22 years ago
Closed 22 years ago
Crash opening cert manager
Categories
(Core Graveyard :: Security: UI, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: KaiE, Assigned: KaiE)
Details
Attachments
(1 file)
1.68 KB,
patch
|
javi
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
Regression from bug 169932.
Open certificate manager => crash
The reasons is a struct that previously contained a plain PRUnichar*.
I changed that to nsString, not noticing the struct is allocated using
nsMemory::Alloc (sigh), and therefore no constructors are getting called.
It doesn't make sense to allocate that struct using nsMemory::Alloc. It is only
being used internally. At least I hope it doesn't make sense.
I'm coming up with a patch that no longer uses nsMemory::Alloc, but C++ new/delete.
Assignee | ||
Comment 1•22 years ago
|
||
Comment 2•22 years ago
|
||
Comment on attachment 100349 [details] [diff] [review]
Patch v1
r=javi
Attachment #100349 -
Flags: review+
Comment 3•22 years ago
|
||
Comment on attachment 100349 [details] [diff] [review]
Patch v1
sr=alecf
Attachment #100349 -
Flags: superreview+
Assignee | ||
Comment 4•22 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•