17103 - [BETA] Using Russian Detector and visiting the URL leads to a crash

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Katsuhiko Momoi]

** Observed with 10/22/99 Win32 M11 build (1999102208)**

Start Mozilla, turn on Russian detector and go visit the
above URL. Mozilla then crashes. I have Talkback incident report
but the Cyclone server is not working well enough to retrieve the
data yet.

The above URL is an ordinary Win-1251 test page containing
no Meta tag or HTTP charset from server.

(** I saw the same crash with the M10 release build though
    Paul Gorodyansky says that he coudl load it with M10.)

Comment 1

[Frank Tang]

Mark it as M14- We should either take out this Russian/Ukrainian detectors or
fix the problem by beta.

Comment 2

[msanz]

Kat, any news with Talkback? Can the stack trace be added? Thanks.

Comment 3

[Katsuhiko Momoi]

Talkback database was wiped off clean recently. So there is no
longer the report I sent. But good news. This crash no longer occurs
with 11/30/99 Win32 build.
I'm going to mark this resolved/worksforme.

Comment 4

[Katsuhiko Momoi]

I'm going to re-open this bug because a crash can be
reproduced by changing the steps a bit.

1. Start up Mozilla browser.
2. Acesss the test page.
3. Turn on the Russian Auto-Detector --> it crashes.

If you reverse the steps 2 and 3, it does not crash.

Comment 5

[Teruko Kobayashi]

Clearing WorksForme..

Comment 6

[Katsuhiko Momoi]

Here's the Talkback report on the crash today:

+++++++++++++++++++++++++++++
Trigger Type:  Program Crash

 Trigger Reason:  Access violation

 Call Stack:    (Signature = nsCyrillicDetector::HandleData 9c233e4f)

   nsCyrillicDetector::HandleData

[d:\builds\seamonkey\mozilla\intl\chardet\src\nsCyrillicDetector.cpp, line 112]

   nsCyrXPCOMDetector::DoIt

[d:\builds\seamonkey\mozilla\intl\chardet\src\nsCyrillicDetector.cpp, line 194]

   nsDetectionAdaptor::RawBuffer

[d:\builds\seamonkey\mozilla\intl\chardet\src\nsDetectionAdaptor.cpp, line 223]

   nsParser::OnStopRequest

[d:\builds\seamonkey\mozilla\htmlparser\src\nsParser.cpp, line 1333]

   nsChannelListener::Init

[d:\builds\seamonkey\mozilla\webshell\src\nsDocLoader.cpp, line 1476]

   nsWebShell::CreatePluginHost

[d:\builds\seamonkey\mozilla\webshell\src\nsWebShell.cpp, line 597]

   nsHTTPResponseListener::ParseStatusLine

[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPResponseListener.cp
p, line 459]

   nsInputStreamChannel::AsyncOpen

[d:\builds\seamonkey\mozilla\netwerk\base\src\nsInputStreamChannel.cpp, line
169]

   nsUnicharStreamLoader::GetNumCharsRead

[d:\builds\seamonkey\mozilla\netwerk\base\src\nsUnicharStreamLoader.cpp, line
124]

   PL_HandleEvent
                                          [plevent.c, line 538]

   _md_EventReceiverProc
                                          [plevent.c, line 976]

   KERNEL32.DLL + 0x363b (0xbff7363b)


   0x06e30016
+++++++++++++++++++++++++++++++++++++++++++

Comment 7

[bobj]

As Frank stated earlier, for Beta, either fix the crash or remove the
Russian auto-detect feature (users still could select specific Russian charset
encodings.

Comment 8

[Frank Tang]

*** Bug 21101 has been marked as a duplicate of this bug. ***

Comment 9

[Frank Tang]

find out the problem. Read/write accros array boundary. Have fix in local code.
Currenty code may cause crash.

Comment 10

[Frank Tang]

*** Bug 17094 has been marked as a duplicate of this bug. ***

Comment 11

[Frank Tang]

add if condicition so we won't access the 128 size character class array when
high bit is off.

Comment 12

[Teruko Kobayashi]

I verified this in 2000020808 Win32, 2000020809 Linux, and 2000020410 Mac build.