171505 - Disabled flags should still be visible in the UI

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Bradley Baetz (:bbaetz)]

As (briefly) discussed on IRC, disabled flags should still who in the UI. They
shouldn't be addable/requestable/etc, though. This is similar to how disabled
products/groups work.

Note that they will still be findable in queries, so having them shown in the UI
is less confusing, anyway, as well as being useful for historical purposes.

If someone truly does't want them shown, then they should be deleted - currently
there is no noticable difference between inactive and deleted (except for the
search thing)

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

Here's the fix for this problem.  I also moved the "show attachment flags or
not" logic out of the template and into the Perl code so if the logic changes
in the future we don't have to modify the "display" template to match it.

Note that the fix for bug 174731 is in this patch, as well as an indenting
correction in attachment.cgi.

Comment 2

[Gervase Markham [:gerv]]

After applying this patch (and unrotting it, correctly I think) then disabled
flags continue to appear on the Edit Attachment screen - but they are still
editable. :-|

Gerv

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: unrotted + can't edit

Ok this patch is unrotted and prevents you from editing the attachment (except
to unset it).

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 105663 [details] [diff] [review]
patch v2: unrotted + can't edit

+    $vars->{'show_attachment_flags'} 
+      = $num_attachment_flag_types + $num_attachment_flags;

Use ||, not +

r=bbaetz, although thre are too many combinations to test reliably. If it
breaks, bmo will let us know in a few hours ;)

Comment 5

[Dave Miller [:justdave]]

a= justdave

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Checking in bug_form.pl;
/cvsroot/mozilla/webtools/bugzilla/bug_form.pl,v  <--  bug_form.pl
new revision: 1.109; previous revision: 1.108
done
Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.30; previous revision: 1.29
done
Checking in template/en/default/attachment/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v
 <--  list.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v 
<--  list.html.tmpl
new revision: 1.3; previous revision: 1.2
done

Comment 7

[Dave Miller [:justdave]]

fixing milestone