171798 - Publish/Save button disabled when editing a document

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[scottputterman]

Using the 9/30 build on XP

Whenever I make changes to a page I'm publishing, the Publish toolbar button
remains disabled.  I have to use Publish As in order to make this work.

I saw this in 2 scenarions.

1.  Edit an already published page. No matter what I typed the button didn't enable.

2.  Create a new page.  Type something.  The publish button is enabled. 
Publish.  From then on the publish button never enables when you make chages to
your document.

Comment 1

[scottputterman]

changing summary.  I just tried this on a document that I've saved locally and
in this case, the publish button is enabled but the save button is disabled
whenever I make changes.  I have to use "Save as" to save my document.

Comment 2

[Jason Bassford]

*** Bug 171943 has been marked as a duplicate of this bug. ***

Comment 3

[Jason Bassford]

*** Bug 171950 has been marked as a duplicate of this bug. ***

Comment 4

[sujay]

--> brade

Comment 5

[Kathleen :Brade]

-->brade

Comment 6

[sujay]

nominating...

Comment 7

[Kathleen :Brade]

Attachment: use non-deprecated APIs

Comment 8

[Charles Manske]

Comment on attachment 101280 [details] [diff] [review]
use non-deprecated APIs

r=cmanske

Comment 9

[Alec Flett]

Comment on attachment 101280 [details] [diff] [review]
use non-deprecated APIs

sr=alecf

Comment 10

[Madhur Bhatia]

i have come across this issue as well in build 2002-10-03trunk

save button is diasbled. even ctrl+s does not work. 
I have to do "file -> save as " to save my document changes.

Comment 11

[Jim Booth]

Using Build 2002100504

After making edits in HTML SOURCE view, the Save Icon and File/Save menu items
are no longer grayed out, BUT CLICKING THEM DOES NOTHING!   The file is not
saved.  Have to use SAVE AS to successfully save the file.  

I suggest this be marked CRITICAL since DATA LOSS results!  This is a regression
since the 9/28 build.

Comment 12

[Jim Booth]

Further info (Build 2002100504):  

If you click SAVE while in HTML SOURCE VIEW, it works.  

To reproduce problem:
1) Open a page in composer NORMAL view, make changes. (Save is grayed out)
2) Switch to HTML SOURCE VIEW, make another change. (Save is NOT grayed out.  It
will work if you click it now.)
3) Switch back to NORMAL view.  (Save remains NOT grayed out, but DOESN'T WORK.)

Comment 13

[jraymond]

I'm noticing this with the 2002100522 Solaris build. I can confirm that changing
something in the HTML Source View does enable the Save button.

Comment 14

[Kathleen :Brade]

The fix here was checked in on October 1 and backed out October 2nd
(inadvertently); I'll reland when the tree opens.

Comment 15

[Kathleen :Brade]

fix checked in again

Comment 16

[Nick Atkins]

Just FYI, I have build 2002100714 and the Puslish icon does not ungrey itself
when you do "File->Edit Page" and start changing the content.

Comment 17

[Judson Valeski]

seeing this again in today's win2k trunk build. upping to critical I was so
close to losing an hour's work because of this.

Comment 18

[Kathleen :Brade]

Attachment: back out 1-line that was incorrectly checked in

The latest problem is unrelated to this bug but I'll attach patch here rather
than create a new bug.	This bug was introduced by a checkin to fix bug 169029.
 A JS function was introduced in the JS but there wasn't any such function. 
Backing out that one line fixes the problem.

Comment 19

[Akkana Peck]

Comment on attachment 102341 [details] [diff] [review]
back out 1-line that was incorrectly checked in

r=akkana

Comment 20

[kinmoz]

Comment on attachment 102341 [details] [diff] [review]
back out 1-line that was incorrectly checked in

sr=[e-mail]

Comment 21

[Kathleen :Brade]

upgrading bug to smoketest blocker to fix the latest regression

Comment 22

[Kathleen :Brade]

fix checked in to trunk

Comment 23

[rubydoo123]

using a trunk build from 20030407 on win2K

There seems to be 3 things here that need to be verified:
1. publish locally
2. publish remotely
3. toggle between HTML and Normal

I have been able to verify both 1 and 3, Chris Petersen will verify #2.

#1
1. I viewed an exisitng html file from my desktop in the browser.
2. I then selected to edit. 
- the 'Save' button was disabled
- the 'Publish' button was enabled

3. I added text to the file
- the 'Save' button was enabled
- the 'Publish' button remained enabled

Create a new document
1. prior to making any enters in the new file
- the 'Save' button was enabled
- the 'Publish' button was enabled

2. entered text in the new file
- the 'Save' button remained enabled
- the 'Publish' button remained enabled

3. Selecting to save the file with the 'Save' button
- the 'Save' button disabled
- the 'Publish' button remained enabled

#2
toggle between Normal and HTML, making changes in HTML mode and selecting 'Save'
and/or 'Publish' worked correctly. The same results occurred

Comment 24

[Chris Petersen]

Yes (based on beppe's steps in #2), the publish part is working fine in both the
2003-04-10-08 Macho and 2003-04-10-04 Win32 trunk builds. Marking verified.