172025 - Cancelling a creation of new bookmark folder still leaves a folder called New Folder

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[André Dahlqvist]

With current CVS of Phoenix, if I right-click on PT and choose New Folder and
hit Cancel a folder named "New Folder" will still appear on the PT. Blake says
the folder is created even before the properties dialog appears.

Comment 1

[Asa Dotzler [:asa]]

Confirmed with a recent linux build (this afternoon)

Comment 2

[Pierre Chanial]

*** Bug 175942 has been marked as a duplicate of this bug. ***

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch to fix.

If the user cancels the properties dialog (or clicks the X box), remove the
folder that was created.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: oops, forgot a line

Comment 5

[André Dahlqvist]

Thanks Ben. I tried this patch on top of current CVS and it worked as expected
(the folder New Folder is removed when you hit Cancel). I tried this on both the
PT and in Manage Bookmarks.

Comment 6

[Pierre Chanial]

cute!
A nit, I'd prefer to define a new function in BookmarksCommand:

openBookmarkProperties (aUrl)
{
  return
openDialog("chrome://browser/content/bookmarks/bookmarksProperties.xul", "",
"centerscreen,chrome,dependent,resizable=no", aUrl);  
}

and use it where it is needed to avoid to return in the openBookmark loop and
avoid js warnings.

Comment 7

[Pierre Chanial]

s/and use/and to use

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: updated patch to address pch's comments

Comment 9

[Pierre Chanial]

fine!
for note: the "properties" case in openBookmark was for opening a property
dialog when ALT-clicking or ALT-ENTER. But it was not used anymore, you was
right to remove it since ALT saves for consistency. If we need it again, it's
easy to set it back.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

-> me

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

fixed!

Comment 12

[Brant Gurganus]

VERIFIED Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030714
Mozilla Firebird/0.6