172210 - Implement a scan mode in mime to make filters job easy

Status: RESOLVED FIXED

(MailNews Core :: MIME, defect)

Description

[Jean-Francois Ducarroz]

We need a new mode in mime to output the data without any HTML/XUL formating. We
cannot use the raw mode of mime as we need the data to be decoded and we want
only data that can be displayed to the user (except images).

Comment 1

[Jean-Francois Ducarroz]

Attachment: Proposed fix, v1 for nsBayesianFIlter.cpp

This patch let run the stream data through the mime converter. Currently mime
does not output a fully clean data but this is much better that having the raw
data.

Comment 2

[Patrick C. Beard]

Comment on attachment 101451 [details] [diff] [review]
Proposed fix, v1 for nsBayesianFIlter.cpp

I went ahead and incorporated the patch.

Comment 3

[Jean-Francois Ducarroz]

Attachment: Proposed fix, v2(mime part)

This patch add a new emitter to allow output headers as plain text. It also add
a new internal mode in mime to allow output plain text without convertion to
HTML. And finaly, multipart/alternative is interpreted as multipart/mixed when
requesting an output for filtering.

Comment 4

[Cavin Song]

Comment on attachment 101568 [details] [diff] [review]
Proposed fix, v2(mime part)

just one minor thing: the define for kIStreamConverterServiceCID does not seem
to be used in the patch so perhaps it can be removed?

Comment 5

[Jean-Francois Ducarroz]

good catch, it was already defined in the middle of the code, that was just a
merge issue. I'll remove it before check it in.

Comment 6

[Patrick C. Beard]

Comment on attachment 101568 [details] [diff] [review]
Proposed fix, v2(mime part)

BTW, you should clean up the .xml file patch, only the new source file changes
are relevant.

sr=beard

Comment 7

[Jean-Francois Ducarroz]

the original xml file has been created with an older version of CW. The new CW
does not export all those Windows Build info. the new XML file will be much
cleaner like that!

Comment 8

[(not reading, please use [e-mail] instead)]

1)

+nsMimePlainEmitter::nsMimePlainEmitter()
+{
+}

are we missing a NS_INIT_REFCOUNT() or anything?  or do we get that from the
base class?

2)

does this (or should this?) emitter affect when we do a plain text reply to a
html message?

the rest seems ok.  if beard has tried it and it works for him, r/sr=sspitzer

Comment 9

[Jean-Francois Ducarroz]

1) correct, the base emitter class will take care of the initialization of the
refcount.

2) This emitter is only used when the parameter header=filter is present in the
URL mime is processing. Nothing to to with regular email processing.

Comment 10

[Jean-Francois Ducarroz]

Comment on attachment 101568 [details] [diff] [review]
Proposed fix, v2(mime part)

I checked in that patch. I keep the bug open in case we need to do more
thing...

Comment 11

[Jean-Francois Ducarroz]

Looks like we are done with that bug, close it