173180 - Rhino UTF-8 decoder accepts overlong sequences

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Phil Schwartau]

This is the Rhino version of bug 172699 against SpiderMonkey.
EXAMPLE: decodeURI("%C0%AF").charCodeAt(0) should result in 65533

The testcase for this is

      mozilla/js/tests/js1_5/Regress/regress-172699.js

which is currently failing in Rhino:


*-* Testcase js1_5/Regress/regress-172699.js failed:
Bug Number 172699
STATUS: UTF-8 decoder should not accept overlong sequences
Failure messages were:
FAILED!: Section 1 of test -
FAILED!: Expected value '65533', Actual value '37'

Comment 1

[Igor Bukanov]

Attachment: Checking for overlong

The patch merges utf8ToOneUcs4Char body into the decode method and adds checks
for overlongs to follow SpiderMonkey.

Comment 2

[Igor Bukanov]

I commited the above patch, so now Rhino passes the tests.

Comment 3

[Phil Schwartau]

Marking FIXED. 

The above testcase now passes for me in the Rhino shells on WinNT,
in both compiled and interpreted mode -

Comment 4

[Phil Schwartau]

Marking Verified -

Comment 5

[Igor Bukanov]

Targeting as resolved against 1.5R4