173586 - [FIX]universal selector * is not prepended to pseudo elements

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P3)

Description

[Vladimir Ermakov]

universal selector * is appended to pseudo classes but not to pseudo elements.
See the testcase.

Comment 1

[Vladimir Ermakov]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

.

Comment 3

[Boris Zbarsky [:bzbarsky]]

So glazou, right now we do not prepend the "*" in the following situations:

1)  we have a tag name (including a pseudo-tag)
2)  we have a class name
3)  we have an ID

It almost seems like we may want to prepend it in all situations when we don't
have a non-pseudo tag name.  Thoghts?

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Excerpt from Selectors CR (http://www.w3.org/TR/css3-selectors)

   Note: it is recommended that the *, representing the universal selector, not be
         omitted.

Comment 5

[Boris Zbarsky [:bzbarsky]]

OK.  should we also do the "all namespace" thing too? So ".foo" would turn into
"*|*.foo" ?

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Beuuuuuhhhh. Hmmm. No. In case of an author stylesheet attached to an HTML
document only, the author does not want to see a namespace prefix, even if it's
perfectly legal...
The perfect solution would be the following one from my perspective :

  1. if no namespace is defined in the sheet, don't do the *| part
  2. if a default namespace is defined, don't do the *| part
  3. in other cases, do the *| part

I don't say it's easily feasible. I say it my best choice. Opinions ?

Comment 7

[Eric A. Meyer (dead account)]

Sorry for the spam, but I was all set to write up a discussion of why this was
wrong when I realized the subject was misleading.  So I'm fixing it.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: More extensive testcase

This tests 4 sheets with slightly different @namespace rule combinations.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch to fix this

This fixes a bug with "|foo" selectors and some other namespace bugs, in
addition to this bug.

Comment 10

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 148008 [details] [diff] [review]
Patch to fix this

yep! r=[e-mail]

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 148008 [details] [diff] [review]
Patch to fix this

Marking Daniel's review.

roc, could you sr?

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 148008 [details] [diff] [review]
Patch to fix this

Er, even type roc's address... )

Comment 13

[Boris Zbarsky [:bzbarsky]]

Fixed.