173827 - NSPR l10n_debug cruft copied into jsprf.c from old prprf.c

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Brendan Eich [:brendan]]

Cc'ing wtc in case it's still there.  The getenv call seems save enough to me,
and the l10n_debug boolean conditions safe-looking printfs, but all this junk
should be #ifdef DEBUG, if it shouldn't be removed altogether.

wtc, do you know the history?  I'll dig into cvs if that contains the answer,
although this may well predate cvs.mozilla.org.

/be

Comment 1

[Wan-Teh Chang]

I know the history but it's not important.
I think all that stuff should be removed
altogether.  It is still in prprf.c.

Comment 2

[Brendan Eich [:brendan]]

Attachment: proposed fix

I also eliminated tabs, stripped trailing whitespace, fixed else-after-break
non-sequiturs, and consolidated a break or two.

/be

Comment 3

[Steven Cole]

Can I also make the suggestion that we change _LEFT, _SIGNED, _SPACED, _ZEROS,
and _NEG with tokens that don't begin with an underscore?  We had a compiler
once that used _LEFT, and this was a problem here...  [I realize that this bug
isn't here to address this, but if jsprf is getting cleaned up it fits.  Sort of.]

--scole

Comment 4

[Brendan Eich [:brendan]]

Attachment: fix with scole's suggested further cleanup

scole, how about an r=?  I'll get this in today with that.

/be

Comment 5

[Steven Cole]

Comment on attachment 106140 [details] [diff] [review]
fix with scole's suggested further cleanup

Looks good to me.  (Thanks for taking my suggestion, Brendan.)

Comment 6

[Brendan Eich [:brendan]]

Fixed on the trunk.

/be

Comment 7

[Wan-Teh Chang]

Attachment: Patch for NSPR's prprf.c

This is Brendan's patch (attachment 106140 [details] [diff] [review]) adjusted
for NSPR's prprf.c.  I've checked it in on the trunk
of NSPR.

Comment 8

[Phil Schwartau]

Both checkins verified on the trunk -