Closed
Bug 174218
Opened 22 years ago
Closed 21 years ago
nsXPInstallManager::ConfirmChromeInstall leaks return from nsTextFormatter::smprintf
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
()
Details
Attachments
(1 file)
|
4.39 KB,
patch
|
dveditz
:
review+
timeless
:
superreview+
|
Details | Diff | Splinter Review |
fwiw, nsXPInstallManager::ConfirmChromeInstall should not call
nsTextFormatter::smprintf directly, it should use the stringbundle api
(formatStringFromName).
|
||
Comment 2•22 years ago
|
||
Comment on attachment 102742 [details] [diff] [review]
patch
Thanks! r=dveditz (or sr=)
Attachment #102742 -
Flags: review+
|
||
Comment 4•22 years ago
|
||
+ if (!confirmText)
+ return PR_FALSE;
Shouldn't that be an IsEmpty() check?
sr=bzbarsky with that change.
Comment on attachment 102742 [details] [diff] [review]
patch
i hit this again. moving it onto my radar.
Attachment #102742 -
Flags: superreview+
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•