174218 - nsXPInstallManager::ConfirmChromeInstall leaks return from nsTextFormatter::smprintf

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[timeless]

fwiw, nsXPInstallManager::ConfirmChromeInstall should not call
nsTextFormatter::smprintf directly, it should use the stringbundle api
(formatStringFromName).

Comment 1

[timeless]

Attachment: patch

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 102742 [details] [diff] [review]
patch

Thanks! r=dveditz (or sr=)

Comment 3

[timeless]

seeking sr

Comment 4

[Boris Zbarsky [:bzbarsky]]

+    if (!confirmText)
+        return PR_FALSE;

Shouldn't that be an IsEmpty() check?

sr=bzbarsky with that change.

Comment 5

[timeless]

Comment on attachment 102742 [details] [diff] [review]
patch

i hit this again. moving it onto my radar.

Comment 6

[timeless]

checked in