174390 - Bookmarks Toolbar overflow doesn't account for toolbar items to the right of the BT; overflow only cares about the browser border.

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect, P2)

Description

[djk]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.2b) Gecko/20021014 Phoenix/0.3
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.2b) Gecko/20021014 Phoenix/0.3

If there are toolbar item(s) to the right of the Bookmarks Toolbar Items, and
the browser window is too narrow, the toolbar items(s) are shoved past the
righthand browser window border.  If the chevron appears, it only shows the
hidden bookmarks toolbar items.  The extra 'normal' toolbar items are not shown.

The bookmarks toolbar overflow should treat other toolbar items that are to the
right of the BT and are against the browser border as if the toolbar items were
the browser border and use the chevron rather than shoving the toolbar items off
view. (good luck parsing that sentence...)


Reproducible: Always

Steps to Reproduce:
1. Shrink browser window horizontally (this makes it easier to see the problem
if you have few BT items)
2. Customize Toolbars...
3. Place a toolbar item to the right of the 'BT Items' (eg the Throbber).
4. Put enough items to the left of the BT Items to overflow the BT.
5. Exit customize toolbars
6. Refresh screen to show the chevron (bug 173493)

Actual Results:  
The item(s) placed to the right of the BT Items in step 3 aren't visable.


Expected Results:  
The item(s) placed to the right of the BT ITems in step 3 should be visable and
bounded by the righthand browser border; the BT should make the chevron appear
to the left of those items.

Comment 1

[Lance L. Forest]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021020 Phoenix/0.3
Reproducable in this build.
Additionally, there are times when the chevron overwrites the last visible BT item.

Comment 2

[Kim]

wfm using Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.2b) Gecko/20021029 Phoenix/0.4

A tiny item of note though, you can still shrink the browser window enough so
that items overflow, but it does take into account for items to the right of
items such as the throbber. (I did reproduce this bug using an earlier build,
but was too tired at the time to add a response)

Comment 3

[Paul Nicholls]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021029 Phoenix/0.4

Reproduced in this build.

Comment 4

[André Dahlqvist]

Confirmed with a build from today on Linux. The reporter is saying that items
other than bookmarks should not be pushed outside of the Bookmark Toolbar as the
browser window is shrunk horisontally. I think this is valid, because then there
is no way to access these items (bookmarks can be accessed though that right-arrow).

Comment 5

[djk]

Attachment: also use widths of items to the right of the bookmarks when calculating overflow

It may not be pretty, but it works for me. :-)

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 106209 [details] [diff] [review]
also use widths of items to the right of the bookmarks when calculating overflow

hyatt, can you take a look at this patch and see if it's something we can use?
Thanks.

Comment 7

[Asa Dotzler [:asa]]

*** Bug 187543 has been marked as a duplicate of this bug. ***

Comment 8

[djk]

Attachment: de-XBLified version of the fix

Comment 9

[djk]

maybe pch could look at this?  he's the px bookmark guru :-)

Comment 10

[Blake Ross]

This patch seems sensible to me. Hey Pierre, can you review it and check it in
if it passes muster?

Comment 11

[Simon Paquet [:sipaq]]

Taking QA Contact

Comment 12

[djk]

hey noririty,

Since you checked in one of my other bookmarks chevron fixes (bug 180156), could
you take a look at this one, too?  It's probably a little bitrotted, but I can
update it if I know someone will look at it.

Thanks,
David

Comment 13

[Simon Paquet [:sipaq]]

*** Bug 178884 has been marked as a duplicate of this bug. ***

Comment 14

[Chris Cook]

I'm still seeing this bug. Was the patch ever reviewed/applied?

Comment 15

[Chris Cook]

Confirming that the current patch resolves the problem. It has suffered bitrot
but manually applying the change fixes the bug.

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 117861 [details] [diff] [review]
de-XBLified version of the fix

r=[e-mail]

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

br & trunk fixed. 

Comment 18

[Stephen Walker]

Could this cause problems if the bookmarks are placed [to the left] on the
primary toolbar?

Comment 19

[djk]

If some object to the right of the Bookmarks Toolbar Items has an inaccurate
'.boxObject.width', then I guess there may be some odd behavior.  Are you seeing
anything strange?

Comment 20

[Stephen Walker]

For each restore/maximize the width of the bookmarks will decrease until
eventually only the chevron is left.

Comment 21

[David Tenser [:djst]]

*** Bug 251659 has been marked as a duplicate of this bug. ***

Comment 22

[Stephen Walker]

Reassigning in hope of getting traction on the regression.

Comment 23

[djk]

(In reply to comment #20)
> For each restore/maximize the width of the bookmarks will decrease until
> eventually only the chevron is left.

I think this regression was filed as bug 269775. It was fixed on 2005-07-18.

Stephen, if bug 269775 is what you were talking about in comment 20, I guess we
can finally close this bug RESOLVED FIXED.  (it looks like that is the case
because bug 269775 comment 14 mentions the boxObject.width, as I did in comment
19 of this bug)

Comment 24

[Stephen Walker]

This regression is partially fixed, but the chevron is still present after
restoring and maximizing the window.

Comment 25

[Mike Connor [:mconnor]]

This seems to be WFM on current trunk, resolving as such.  If this is still a problem after the Places landing, please file a new bug there.