174432 - toolbox no longer picks up -moz-appearance

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Brian Ryner (not reading)]

After the checkin to remove the toolbar grippies, toolbox no longer picks up the
-moz-appearance (actually, it doesn't pick up any of the skin-specific CSS). 
The reason appears to be that the toolbox binding was removed, so it no longer
inherits from toolbar-base which is what pulls in chrome://global/skin/toolbar.css.

Comment 1

[Jan Varga [:janv]]

Attachment: proposed patch

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 103007 [details] [diff] [review]
proposed patch

why not just use toolbar-base as the binding?

Comment 3

[Jan Varga [:janv]]

You are right, new patch coming

Comment 4

[Jan Varga [:janv]]

Attachment: patch which doesn't work

So it seems it's not possible to use base binding that doesn't have content
defined.
With this patch I got navigation toolbar w/o URL bar.

Comment 5

[Jan Varga [:janv]]

I'm a moron.
When I updated my tree in bindings directory it patched textbox.xml too
So it didn't work.
Sorry for the SPAM.
Second patch should work.

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 103167 [details] [diff] [review]
patch which doesn't work

If you've tested this and it works, r=bryner.

Comment 7

[Brian Ryner (not reading)]

*** Bug 175099 has been marked as a duplicate of this bug. ***

Comment 8

[Paul McGarry]

Please check that Bug 175099 is in fact a duplicate of this bug.
The GTK background pixmap referred to there should appear everywhere (dialogue
boxes, etc etc) not just in the toolbar.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 103167 [details] [diff] [review]
patch which doesn't work

sr=[e-mail]

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 103167 [details] [diff] [review]
patch which doesn't work

a=dbaron for trunk checkin

Comment 11

[Jan Varga [:janv]]

fixed

Comment 12

[Jan Varga [:janv]]

really fixed

Comment 13

[Patty Mac]

Verified the patch