174541 - "Set as Personal Toolbar" should be in "Edit" menu, not in "View"

Status: RESOLVED INVALID

(SeaMonkey :: Bookmarks & History, enhancement)

Description

[Stephan Hohe]

In the Bookmark Manager the menu items
  "Set as New Bookmarks Folder"
  "Set as New Internet Search Folder"
  "Set as Personal Toolbar Folder"
are located in the "View" menu.

Expected: This commands should be in the Edit menu, because they have nothing to
do with viewing. They edit attributes of the bookmark folders.

Comment 1

[Chris Lyon]

Can't argue with that logic.

Confirming as RFE.

Comment 2

[Jonathan Harford]

I didn't even know that one could declare a Bookmark Folder as one's Personal
Toolbar Folder. I'd been trying to do with the folder context menu (i.e.,
right-click). I'd say that THAT is where "Set as Personal Toolbar Folder" should
be-- not in Edit or View.

Comment 3

[Stephan Hohe]

Maybe it should be in the context menu too, but in any case it should be
reachable in the main Edit menu. To maybe put it also in the context menu is an
other thing. You should file an own bug about that.

Comment 4

[Matthias Versen [:Matti]]

*** Bug 197632 has been marked as a duplicate of this bug. ***

Comment 5

[Jure Repinc (JLP)]

I agree with both. These options should be in Edit menu and there should be menu
entries for them in the context menu. Is anyone working on fixing this?

Comment 6

[Žiga Sancin]

Filling another bug for Firefox, taking this one... I hope we can get it in for
1.8a2.

Comment 7

[Žiga Sancin]

Attachment: patching bookmarks.js

adding context menu settings for "Set as New Bookmark Folder", "Set as Saved
Search Results Folder" and "Set as Personal Toolbar Folder".

Comment 8

[Žiga Sancin]

Attachment: patching bookmarksManager.xul

Moving "Set as New Bookmark Folder", "Set as Saved
Search Results Folder" and "Set as Personal Toolbar Folder" settings from the
view menu to the edit menu.

Comment 9

[Žiga Sancin]

requesting blocking flag for 1.8a2 to invoke review...

Comment 10

[Peter Weilbacher]

You should select a different reviewer for these patches, Ben isn't interested in the suite any more. I am not sure if these patches are still up to date with the current trunk (I guess not). So if you update them, have a look on <http://www.mozilla.org/hacking/reviewers.html> for xpfe peers (for sr). I believe r could also come from iann or kairo. I also reassign to you for the same reason.

Comment 11

[Žiga Sancin]

Attachment: combined patch

I know Ben's not doing Mozilla Suite/SeaMonkey development anymore (he was the assignee). Neither do I. ;) Anyhow, here's a combined patch (the bookmarks.js change adds the settings to the context menu and the change in bookmarksManager.xul moves the settings to the view menu).

I talked to Neil about this bug one year ago, but he only cc'ed Pierre to this bug... and nothing has happened since then. Trying aggressively... Neil!!! ;)

Comment 12

[[e-mail]]

Comment on attachment 209371 [details] [diff] [review]
combined patch

Well, full marks for achievement, the patch does what it says. But I'm doubtful as to the usefulness of either aspect of the patch; the context and edit menus are long enough as it is while the new view menu is pathetically short. But I'm generously giving you a second chance by asking for jag's opinion.

Comment 13

[jag (Peter Annema)]

Comment on attachment 209371 [details] [diff] [review]
combined patch

I don't think people change which folder their "new bookmark folder" is often enough to warrent an entry in the context menu. Same for the others.

I'm torn on the bookmarksManager.xul changes though. They don't belong under View I don't think, but removing them does leave View rather empty. Perhaps that's ok.

If we do move them under Edit, could it be under a "Set as" submenu?

Sorry it took so long to respond.

Comment 14

[Jens Hatlak (:InvisibleSmiley)]

The option is gone since the landing of Places-based bookmarks (which happened on the road to SM 2.1), and won't return.