174927 - nsNativeThemeGTK cleanup

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Brian Ryner (not reading)]

There's currently a poor division of code between nsNativeThemeGTK.cpp and
gtkdrawing.c  What I'd like to do is have gtkdrawing be self-contained and
reusable outside of Mozilla.  nsNativeThemeGTK should use the gtkdrawing API and
not have any code to deal with the prototype native widgets. This means that:

- the various GtkWidgets that are used in gtkdrawing.c and nsNativeThemeGTK
should be made private to gtkdrawing.c.

- api's should be added to gtkdrawing.h as needed to make the widgets private to
gtkdrawing.c.

In addition, I cleaned up the interface by changing GdkWindow parameters to
GdkDrawable (since they're in fact pixmaps most of the time), eliminating
GtkStyle parameters from the the painting functions (since this can all be
handled internally), and fully documented the interface.

Comment 1

[Brian Ryner (not reading)]

Attachment: cleanup patch

Comment 2

[Brian Ryner (not reading)]

Attachment: patch #2

removed an extra printf

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 103153 [details] [diff] [review]
patch #2

not ready for review yet, found a couple of problems.

Comment 4

[Brian Ryner (not reading)]

Attachment: new cleanup patch

changes from the last patch:

- replaced all of the individual widget drawing functions in gtkdrawing.h with
one function that takes a widget type constant.
- did the same for the widget border functions
- got rid of javadoc-style comments since javadoc doesn't understand C API's
- fixed the focus state with dropdown textfields
- removed some more unused cruft

Comment 5

[Brian Ryner (not reading)]

Attachment: fix a problem with the last patch

oops, must not have compiled that last one before attaching it (missing a ||).

Comment 6

[Brian Ryner (not reading)]

Attachment: fix border problem

Fixed a problem with widget borders in the last patch

Comment 7

[Biswapesh Chatterjee]

Is this patch ready to be tested ? I'd like to make this a basis for doing some
similar theme stuff for OOo. How difficult is it to seperate this from the
Mozilla tree and build independently ?

Comment 8

[Brian Ryner (not reading)]

Once this lands, gtkdrawing.c should be able to be compiled completely
independently from Mozilla.

Comment 9

[Brian Ryner (not reading)]

Attachment: new patch against the trunk

no functional changes, just merged up to the current trunk version of
nsNativeThemeGTK.cpp

Comment 10

[Robin Lu]

Could we use gtk_paint_slider instead of gtk_paint_box while painting the thumb?

Comment 11

[Brian Ryner (not reading)]

gtk_paint_slider is used for the GtkVScale and GtkHScale widgets, not for the
scrollbar thumb.

Comment 12

[Robin Lu]

yes. I found the slight difference in gtkrange.c of gtk1.2 and gtk2.0

My another question is if we could use some post binding way to reduce the
switch-case check. 

Comment 13

[Brian Ryner (not reading)]

Attachment: merge theme engine blacklisting

Comment 14

[Christopher Blizzard (:blizzard)]

Comment on attachment 107685 [details] [diff] [review]
merge theme engine blacklisting

r=blizzard

Comment 15

[jag (Peter Annema)]

Comment on attachment 107685 [details] [diff] [review]
merge theme engine blacklisting

rs=jag (as said on irc)

Comment 16

[Brian Ryner (not reading)]

finally checked in.