175232 - Implement bookmark folder as start-up page

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement)

Description

[Marc Boullet]

Mozilla have it. Chimera is planning to have it.

Any plan here ?

Notice that Mozilla implementation is annoying when you're behind a proxy
with authentication since it popups a lot of windows requesting Name+password.

Comment 1

[Asa Dotzler [:asa]]

This is either worksforme, wontfix, or fixed. The decision was made to allow
multiple start-up URLs to be listed in the startup preference. This was
implemented and is working.  I'm resolving this as worksforme since it's
slightly different but covers the same behavior and won'tfix doesn't quite seem
to fit.

Comment 2

[Marc Boullet]

Asa,
I don't agree with this WFM.

If I follow your reasoning, we could suppress the "Use Bookmark..." button as
well since you can done load the bookmark in a single tab and use the "Use
current Pages" button to register the URL as the homepage.

I have a 15 lines patch I will attach when I'll get the patchmaker working.

So I reopen the bug. Feel free to mark it Won't fix when the patch has been
produced.

Comment 3

[Marc Boullet]

Attachment: patch

s/done // in previous comment.
Patch for bookmark folder homepage

Comment 4

[Pierre Chanial]

Comment on attachment 107572 [details] [diff] [review]
patch

Thank you Marc for working on this. I planned to fix that. 

> function onOK(aEvent)
> {
>   var selection = gBookmarkTree._selection;
>-  var url = BookmarksUtils.getProperty(selection.item[0], NC_NS+"URL", gBookmarkTree.tree.database);
>+  if (selection.type[0].indexOf("Folder") == -1)
In this particular case, you should better use selection.isContainer[0]

>+    var url = BookmarksUtils.getProperty(selection.item[0], NC_NS+"URL", gBookmarkTree.tree.database);
>+  else
>+    var url = BookmarksUtils.getURIsFromFolder(selection.item[0], gBookmarkTree.tree.database);
Include the loop here, excluding subfolders. No recursive helper, it could lead
to an insane number of home pages and would not be consistent with the 'open in
tabs' action.

In addition, it would be better not to compute the home page string here so we
could check that empty folders (or folders containing only folders) would not
enable the OK button.

take your time to update your patch, I won't have time unfortunately to
re-review it and check it in before ~10 days.

Comment 5

[Marc Boullet]

Attachment: New patch per pch's comment

Pierre,

Here is a new patch.
I'm wondering if, in updateOK, we could use isContainer[0] instead of 3
comparisons (in our particular case, it should work). BTW, it is not
important.

Comment 6

[Marc Boullet]

Attachment: better patch

Pierre,

Final (?) patch. I get rid of the global variable I introduced.

Good luck for your "exams".

Comment 7

[Marc Boullet]

Attachment: New patch

This new patch performs a sanity check to ensure that the
number of Uris is not insane.

Comment 8

[Pierre Chanial]

I checked in a version that also enable to select multiple bookmarks. Merci Marc!
I postponed the limitation on the number of pages since we should decide a
consistent behaviour for opening a folder in tabs.

Comment 9

[noririty]

v.