175683 - Unable to press Enter for OK upon entering secure page

Status: RESOLVED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Kevin Chen]

Whenever I go to a secure page, I get the message "You have requested an
encrypted page..."  To clear the message, I can click the OK button.  Pressing
Enter does not do anything, though.  The same applies to the message produced
upon exiting a secure page.

The Enter key should be allowed as it is much more convenient then using the mouse.

I'm using 2002101412 on WinXP.

Comment 1

[:deanis74]

The easy way to fix this would be to focus on the OK button instead of the check
box.

Comment 2

[:deanis74]

Actually, nothing has focus when this dialog opens, thus the lack of keyboard 
support.  It looks like bug 133582 has regressed.

Comment 3

[:deanis74]

Actually, no, the fix for that bug was with the fix for bug 134066, which 
specifically has:

+  if (setCheckbox(gCommonDialogParam.GetString(1), gCommonDialogParam.GetInt
(1))) {
+    firstButton.focus(); // Don't focus checkbox, focus first button instead
+  }

Comment 4

[:deanis74]

Attachment: patch

About 45 lines above this code is this:

switch (nButtons) {
  case 1:
    dialog.getButton("cancel").hidden = true;

It doesn't make much sense that we are hiding the cancel button and then
setting it up as the button displayed when the number of buttons is 1. 
Especially when we call |firstButton.focus;| below this code, which is focusing
onto the hidden cancel button.

Comment 5

[[e-mail]]

aaron, dean, I've already filed bug 172691 on the buggy focus behaviour -
attachment 102389 [details] [diff] [review] should resolve this problem as well.

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Mass un-assigning bugs assigned to Aaron.

Comment 7

[Asa Dotzler [:asa]]

This UI doesn't seem to exist any more. Any reason to keep this bug open?

Comment 8

[Kevin Chen]

Resolving sounds good to me.