175853 - Update localeVersion strings for 1.2 final - and do it correctly!

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect, P1)

Description

[Robert Kaiser]

localeVersion strings must again be updated for 1.2 final, as we had some
problems with that automatic script of leaf, I think we should do it manually
this time, at least for the final, so that we don't break it once again.

The problems we had with the last updates were tracked in bug 168923 and bug
174989 - and we shouldn't have any such problems left once bug 169074 can be solved.

I'll provide a patch in the next days, and I think it should go in some days
before the release (so that it can be tested a bit), and not only hours before
like with 1.2b...

Comment 1

[Asa Dotzler [:asa]]

Can't release 1.2 without this being done (adding dependency). Thanks for
staying on top of this Robert.

Comment 2

[rchen]

It looks like leaf's.  -->leaf

Comment 3

[Robert Kaiser]

taking, adding leaf to cc, patch follows

Comment 4

[Robert Kaiser]

Attachment: patch: change all contents.rdf PLUS those two .dtd files to 1.2

This patch changes localeVersion="1.2b" to localeVersion="1.2" in all affected
contents.rdf files (hopefully) AND those two .dtd files (brand.dtd, region.dtd)


It's untested currently, I'll test it and check if I could have missed anything
before even requesting a= :)

Comment 5

[Robert Kaiser]

OK, grep doesn't show any localeVersion= in my tree that doesn't end up with
"1.2", that's good. I'm currently building this all, and trying to apply a
german language pack that is set to 1.2 - but it should work well.

jbetak, can you r= this patch?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 103750 [details] [diff] [review]
patch: change all contents.rdf PLUS those two .dtd files to 1.2

sr=bzbarsky

Comment 7

[[e-mail] (away - not reading bugmail)]

Comment on attachment 103750 [details] [diff] [review]
patch: change all contents.rdf PLUS those two .dtd files to 1.2

r=jbetak

kairo, we need to work with leaf on this.

He runs the scripts attached to bug 154927 for every release. He considers them
a temp solution and they have not been maintained in a while. That's the root
of the problem.

There are two more bugs aiming at making the whole process a little better and
more robust: bug 157806 and bug 175140.

Comment 8

[Robert Kaiser]

Thanks for r/sr and your comments.

I just tested my build (with the patch applied) together with a XPI language
pack that is set to a 1.2 version string and it works perfectly!

Comment 9

[[e-mail] (away - not reading bugmail)]

cool - thanks for doing this kairo!

I'm adding dependency on bug 154927. I AIMed with leaf and we are going to
update the release scripts. Although we might get it right before the final 1.2
build, I'd suggest we land this patch soon. Any chance Asa would give you trunk a=?

Comment 10

[Robert Kaiser]

jbetak:
I already requested a= for the patch.

I'd suggest to try new release scripts and stuff when 1.2 is branched, so any
problems might eventually hit the 1.3a builds but not the 1.2 release. After
missing the 1.2a and 1.2b without being able to provide language packs, I'm
eager to give my/our users something new and not to risk experiments.
I'll be quite happy if we can get bug 154927 fixed though, as it is a pain to
always need such a big checkin just for the localeVersion change. I think the
build system should do that for us somehow.

Comment 11

[[e-mail] (away - not reading bugmail)]

right, having this on the trunk will gloss over any potential script problems.

Tao and Don Bragg used to land these patches manually 1 or 2 days before a
release, but it was such a headache that they decided to create release scripts
and transfer the task to leaf. 

However with some many scattered files, it's a now a maintenance headache and
nobody can really expect the release team to be hunting for new instances of
localeVersion in the tree. 

I'll bug 157806 my priority. We need to reduce the number of files that need to
be changed for any given release. Leaf assured me that the release team will
then plug the reduce file set into the build system.

Comment 12

[Christopher Blizzard (:blizzard)]

Comment on attachment 103750 [details] [diff] [review]
patch: change all contents.rdf PLUS those two .dtd files to 1.2

a=blizzard on behalf of drivers for 1.2final

Check it in whenever you guys are ready.

Comment 13

[Robert Kaiser]

checked in changes for the following files (should be all, and should be the
same list as in the patch - as I used this list to create the patch):

directory/xpcom/base/resources/content/contents.rdf
directory/xpcom/base/resources/locale/en-US/contents.rdf
editor/ui/composer/content/contents-region.rdf
editor/ui/composer/content/contents.rdf
editor/ui/composer/locale/en-US/contents-region.rdf
editor/ui/composer/locale/en-US/contents.rdf
extensions/irc/xul/content/contents.rdf
extensions/irc/xul/locale/en-US/contents.rdf
extensions/help/resources/content/contents.rdf
extensions/help/resources/locale/en-US/contents.rdf
extensions/pref/autoconfig/resources/content/contents.rdf
extensions/pref/autoconfig/resources/locale/en-US/contents.rdf
extensions/cookie/resources/content/contents.rdf
extensions/cookie/resources/locale/en-US/contents.rdf
extensions/editor/cascades/resources/locale/en-US/contents.rdf
extensions/venkman/resources/content/contents.rdf
extensions/venkman/resources/locale/en-US/contents.rdf
extensions/wallet/resources/content/contents.rdf
extensions/wallet/resources/locale/en-US/contents.rdf
extensions/content-packs/resources/content/contents.rdf
extensions/content-packs/resources/locale/en-US/contents.rdf
extensions/inspector/resources/content/contents.rdf
extensions/inspector/resources/locale/en-US/contents.rdf
extensions/transformiix/resources/contents.rdf
layout/html/forms/resources/locale/en-US/contents.rdf
mailnews/base/resources/content/contents-region.rdf
mailnews/base/resources/content/contents.rdf
mailnews/base/resources/locale/en-US/contents-region.rdf
mailnews/base/resources/locale/en-US/contents.rdf
mailnews/mapi/resources/content/contents.rdf
mailnews/mapi/resources/locale/en-US/contents.rdf
mailnews/extensions/mdn/resources/content/contents.rdf
mailnews/extensions/mdn/resources/locale/en-US/contents.rdf
mailnews/extensions/smime/resources/content/contents.rdf
mailnews/extensions/smime/resources/locale/en-US/contents.rdf
mailnews/extensions/smoketest/resources/content/contents.rdf
netwerk/resources/content/contents.rdf
netwerk/resources/locale/en-US/contents.rdf
security/manager/pki/resources/content/contents.rdf
security/manager/pki/resources/locale/en-US/contents.rdf
security/manager/ssl/resources/content/contents.rdf
security/manager/ssl/resources/locale/en-US/contents.rdf
xpfe/communicator/resources/content/contents-region.rdf
xpfe/communicator/resources/content/contents-platform.rdf
xpfe/communicator/resources/content/contents.rdf
xpfe/communicator/resources/locale/en-US/mac/contents-platform.rdf
xpfe/communicator/resources/locale/en-US/win/contents-platform.rdf
xpfe/communicator/resources/locale/en-US/unix/contents-platform.rdf
xpfe/communicator/resources/locale/en-US/contents-region.rdf
xpfe/communicator/resources/locale/en-US/contents.rdf
xpfe/components/prefwindow/resources/locale/en-US/mac/contents-platform.rdf
xpfe/components/prefwindow/resources/locale/en-US/win/contents-platform.rdf
xpfe/components/prefwindow/resources/locale/en-US/unix/contents-platform.rdf
xpfe/components/autocomplete/resources/locale/en-US/contents.rdf
xpfe/components/download-manager/resources/mac/contents.rdf
xpfe/global/resources/content/contents-region.rdf
xpfe/global/resources/content/contents-platform.rdf
xpfe/global/resources/content/contents.rdf
xpfe/global/resources/locale/en-US/mac/contents-platform.rdf
xpfe/global/resources/locale/en-US/os2/contents-platform.rdf
xpfe/global/resources/locale/en-US/win/contents-platform.rdf
xpfe/global/resources/locale/en-US/unix/contents-platform.rdf
xpfe/global/resources/locale/en-US/contents-region.rdf
xpfe/global/resources/locale/en-US/contents-region.rdf
xpfe/global/resources/locale/en-US/contents.rdf
xpfe/global/resources/locale/en-US/contents.rdf
xpfe/browser/resources/content/mac/contents-platform.rdf
xpfe/browser/resources/content/win/contents-platform.rdf
xpfe/browser/resources/content/unix/contents-platform.rdf
xpfe/browser/resources/content/contents-region.rdf
xpfe/browser/resources/content/contents.rdf
xpfe/browser/resources/locale/en-US/mac/contents-platform.rdf
xpfe/browser/resources/locale/en-US/win/contents-platform.rdf
xpfe/browser/resources/locale/en-US/unix/contents-platform.rdf
xpfe/browser/resources/locale/en-US/contents-region.rdf
xpfe/browser/resources/locale/en-US/contents.rdf
xpfe/global/resources/locale/en-US/brand.dtd
xpfe/global/resources/locale/en-US/region.dtd

marking FIXED.