176096 - Mozilla (Firebird) should not register as default HTML editor, when Composer is not installed.

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Kevin Stange]

In Phoenix 0.3, right clicking on a .html and selecting edit, after setting
phoenix as the default browser, will cause phoenix to open and display the home
page.  Phoenix registers itself in Windows as an html editor, even though it
isn't, and tries to set itself as the default.

I can change my HTML editor back to what I want from the Internet control panel.

Comment 1

[Simon Paquet [:sipaq]]

I don't see this on my 10/22/2002 build under W2k.
Kevin, what build are you using?

Comment 2

[d robertson]

I see this on Windows 2000.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021023 Phoenix/0.3

If you go into windows explorer and right-click on an .html file, hit edit on
the popup menu, the .html file will open in the Phoenix browser.  If I change my
default .html browser back to Netscape7 or IE, then the edit function opens up
the .html file in Netscape7 composer, as it should.

If I go onto IE's settings, under programs, Phoenix is listed as an html editor.
 Phoenix probably should not be listed here.  Strangely, Phoenix is never
highlighted as the chosen editor in this dropdown, it is only listed there. 
Netscape7 composer (NETSCP) is always highlighted, regardless of what the
default browser is.  But when Phoenix is the default browser, it seems to
"override" the html editor selection in IEs settings, and opens up .html pages
for the edit function.

Sounds like Phoenix is using Mozilla code when registering itself as the default
browser and registering itself as a html editor aswell.  It should only register
itself as the browser and leave the editor settings asis.

Comment 3

[Marc Boullet]

Marking NEW per previous comments. Severity to normal.

Comment 4

[Brander Roullett]

I see this issue as well using Phoenix 0.5 and Windows XP

Comment 5

[Sébastien Delahaye]

*** Bug 186644 has been marked as a duplicate of this bug. ***

Comment 6

[Sébastien Delahaye]

*** Bug 184193 has been marked as a duplicate of this bug. ***

Comment 7

[Olivier Mengué]

See bug #186644 for information about some registry keys involved.

Comment 8

[Forest]

I can confirm that this problem shows up with Phoenix 0.5 on Windows 2000 sp3.

Comment 9

[Sam Katz]

A little clarification:

In windows ME, Phoenix is selected in the dropdown menu as an HTML editor. When
either Mozilla  1.3 <date> or Phoenix 0.5 is set as "default".. they take over
the html editor. I think this is a bug in both browsers, although in my case, I
want composer as my default. But phoenix not having composer should definitely
not take over the html editor.

also, phoenix lacks an edit menu item in the file menu (it should have one,
which respects your html editor preference.) But that is a rfe.

Sam

Comment 10

[Sam Katz]

My comment made no sense.

1. Given: any mozilla.org product should ask before taking over file types.
Fact: neither Mozilla or Phoenix ask to take over the html editor.
2. Phoenix should not register as an HTML editor, or any file type which it
cannot handle. It should not act like Mozilla. (can/should we create a meta-bug
for this?). "new subroutines that have to be written to prevent phoenix from
acting like Mozilla"

Is subroutines the correct term?
This is a bug in Phoenix, not Mozilla.

Comment 11

[:deanis74]

http://lxr.mozilla.org/seamonkey/source/xpfe/components/winhooks/nsWindowsHooks.cpp#594

mozillaMarkup is an EditableFileTypeRegistryEntry, which just blindly assumes
that we support an HTML editor.

http://lxr.mozilla.org/seamonkey/source/xpfe/components/winhooks/nsWindowsHooksUtil.cpp#726

This is a problem not only for Phoenix, but also for any custom installation
that doesn't include Composer.  I think the way to fix this is to first make
sure we support a composer and only then set the option.

cc: law -- Bill, do you agree with this approach?

Comment 12

[:deanis74]

Attachment: patch

This fixes the problem on Phoenix.  I'm not sure if I'm checking properly if
Composer's installed, though.  Who could answer this?  Better yet, can someone
try this on a Mozilla build?

Comment 13

[:deanis74]

Attachment: patch v2

This is better, it checks that we support "-edit" on the command-line.

Comment 14

[:deanis74]

See bug 196522 for breaking the default editor-setting code out.

Comment 15

[Simon Paquet [:sipaq]]

Dean, what is holding this on the Phoenix side?

Comment 16

[:deanis74]

See comment 11.  This is not a Phoenix bug, it's a core bug.

Comment 17

[Simon Paquet [:sipaq]]

Moving over to Mozilla Browser and changing summary.

Comment 18

[Bill Mason]

*** Bug 214056 has been marked as a duplicate of this bug. ***

Comment 19

[:deanis74]

timeless checked this in this morning

Comment 20

[Jesse Ruderman]

*** Bug 227564 has been marked as a duplicate of this bug. ***

Comment 21

[Ryan Polk (Quark)]

*** Bug 244207 has been marked as a duplicate of this bug. ***